BCR presubmit: Support testing test module #1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wyverald
reviewed
Jan 11, 2022
buildkite/bazelci.py
Outdated
| With matrix = {'a': [1, 2], 'b': [1], 'c': [2]}, | ||
| if attributes = ['a', 'b'], then returns [[('a', 1), ('b', 1)], [('a', 2), ('b', 1)]] | ||
| if attributes = ['b', 'c'], then returns [[('b', 1), ('c', 1)]] | ||
| if attributes = ['c'], then returns [[('c', 1)]] |
There was a problem hiding this comment.
Nice catch, but I'll fix the matrix instead.
There was a problem hiding this comment.
Also rebase with master branch after merging #1300
BCR modules can now specify task configurations for a test module under `bcr_test_module`. Closes: #1302
meteorcloudy
force-pushed
the
bcr_test_module
branch
from
688ac93 to
aa57834
Compare
seh
reviewed
Jan 23, 2023
| output_dir = root.joinpath("output") | ||
| bazelci.eprint("* Download and unpack %s\n" % archive_url) | ||
| download(archive_url, archive_file) | ||
| shutil.unpack_archive(str(archive_file), output_dir) |
There was a problem hiding this comment.
At present, we lose the permissions on the extracted files, per python/cpython#59999.
fmeum
pushed a commit
to fmeum/continuous-integration
that referenced
this pull request
Dec 10, 2023
BCR modules can now specify task configurations for a test module under `bcr_test_module`. Closes: bazelbuild#1302
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing #1302