Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incompatible_blacklisted_protos_requires_proto_info: Require ProtoInfo provider for proto_lang_toolchain.blacklisted_protos #11694

Closed
Yannic opened this issue Jul 2, 2020 · 3 comments
Closed

incompatible_blacklisted_protos_requires_proto_info: Require ProtoInfo provider for proto_lang_toolchain.blacklisted_protos #11694

Yannic opened this issue Jul 2, 2020 · 3 comments
Assignees
@Yannic
Labels
incompatible-change Incompatible/breaking change team-Rules-Server Issues for serverside rules included with Bazel type: process untriaged

Comments

@Yannic
Copy link
Contributor

Yannic commented Jul 2, 2020 •
edited
Loading

Flag: --incompatible_blacklisted_protos_requires_proto_info

Prevents users from passing .proto files / filegroups to proto_lang_toolchain.blacklisted_protos.

Migration

For most users, migration is straight forward. All that is required is upgrading Protobuf to v3.13.0 (or later).

When using proto_lang_toolchain directly

If you're using proto_lang_toolchain directly, you need to replace the files in
proto_lang_toolchain.blacklisted_protos with the proto_library targets containing these files.

For WKPs, this would mean replacing

proto_lang_toolchain(
    name = "my_proto_toolchain",
    blacklisted_protos = [
        "@com_google_protobuf//:src/google/protobuf/any.proto",
        "@com_google_protobuf//:src/google/protobuf/descriptor.proto",
        # ...
    ],
    # ...
)

with

proto_lang_toolchain(
    name = "my_proto_toolchain",
    blacklisted_protos = [
        "@com_google_protobuf//:any_proto",
        "@com_google_protobuf//:descriptor_proto",
        # ...
    ],
    # ...
)
@Yannic
Copy link
Contributor Author

Yannic commented Jul 2, 2020

@meisterT FYI so it gets all the required labels for migration (expecting to flip in 4.0).

@meisterT meisterT added incompatible-change Incompatible/breaking change migration-3.4 labels Jul 2, 2020
@meisterT
Copy link
Member

meisterT commented Jul 2, 2020

cc @comius

@gregestren gregestren added team-Rules-Server Issues for serverside rules included with Bazel untriaged type: process labels Jul 7, 2020
Yannic added a commit to Yannic/bazel that referenced this issue Jul 20, 2020
@Yannic
Upgrade protobuf to 4.0.0-rc1, part 1/3
5ded2fa 
This change includes the third_party changes neccessary to upgrade
protobuf to 4.0.0-rc1.

Note that the bump of protobuf's major version was neccessary because of
a breaking change in PHP which Bazel isn't affected by.

Working towards making Bazel compatible with bazelbuild#11694
@Yannic Yannic mentioned this issue Jul 20, 2020
Closed
@Yannic Yannic mentioned this issue Aug 18, 2020
Merged
Yannic added a commit to Yannic/bazel that referenced this issue Sep 2, 2020
@Yannic
Upgrade protobuf to 3.13.0, part 1/3
6262232 
This change includes the third_party changes neccessary to upgrade
protobuf to 3.13.0.

Working towards making Bazel compatible with bazelbuild#11694
Yannic added a commit to Yannic/bazel that referenced this issue Sep 2, 2020
@Yannic
Flip --incompatible_blacklisted_protos_requires_proto_info
e4dd197 
Fixes bazelbuild#11694
@Yannic Yannic mentioned this issue Sep 2, 2020
Closed
Yannic added a commit to Yannic/bazel that referenced this issue Sep 2, 2020
@Yannic
Upgrade protobuf to 3.13.0, part 1/3
581b71d 
This change includes the third_party changes neccessary to upgrade
protobuf to 3.13.0.

Working towards making Bazel compatible with bazelbuild#11694
Yannic added a commit to Yannic/kythe that referenced this issue Sep 4, 2020
@Yannic
build: upgrade Protobuf to v3.13.0
297a674 
This makes kythe compatible with
`--incompatible_blacklisted_protos_requires_proto_info`.
See bazelbuild/bazel#11694
@Yannic Yannic mentioned this issue Sep 4, 2020
Merged
Yannic added a commit to Yannic/cartographer that referenced this issue Sep 4, 2020
@Yannic
Upgrade Protobuf to v3.13.0
15c1754 
This makes cartographer compatible with
`--incompatible_blacklisted_protos_requires_proto_info`.
See bazelbuild/bazel#11694

Signed-off-by: Yannic Bonenberger <contact@yannic-bonenberger.com>
@Yannic Yannic mentioned this issue Sep 4, 2020
Merged
wohe pushed a commit to cartographer-project/cartographer that referenced this issue Sep 14, 2020
@Yannic
Upgrade Protobuf to v3.13.0 (#1746)
f2035b0 
This makes cartographer compatible with
`--incompatible_blacklisted_protos_requires_proto_info`.
See bazelbuild/bazel#11694

Signed-off-by: Yannic Bonenberger <contact@yannic-bonenberger.com>
bazel-io pushed a commit that referenced this issue Sep 16, 2020
@Yannic @meteorcloudy
Upgrade protobuf to 3.13.0, part 1/3
35b3780 
This change includes the third_party changes neccessary to upgrade
protobuf to 3.13.0.

Working towards making Bazel compatible with #11694

Closes #11807
Yannic added a commit to Yannic/bazel that referenced this issue Sep 16, 2020
@Yannic
Upgrade protobuf to 3.13.0, part 2/3
4021512 
This change does the actual upgrade of Protobuf. I'll send
a follow-up to remove the now-unused path-file for `3.11.3`
when this has landed (and there is no risk of a rollback).

Working towards making Bazel compatible with bazelbuild#11694
Yannic added a commit to Yannic/bazel that referenced this issue Sep 16, 2020
@Yannic
Upgrade protobuf to 3.13.0, part 2/3
9ddd713 
This change does the actual upgrade of Protobuf. I'll send
a follow-up to remove the now-unused path-file for `3.11.3`
when this has landed (and there is no risk of a rollback).

Working towards making Bazel compatible with bazelbuild#11694
@Yannic Yannic mentioned this issue Sep 16, 2020
Closed
shahms added a commit to kythe/kythe that referenced this issue Sep 16, 2020
@Yannic @shahms
build: upgrade Protobuf to v3.13.0 (#4681)
53973c5 
* build: upgrade Protobuf to v3.13.0

This makes kythe compatible with
`--incompatible_blacklisted_protos_requires_proto_info`.
See bazelbuild/bazel#11694

* Run kythe/proto/generate_go_protobufs.py

* Update kythe/go/util/riegeli/riegeli_test_go_proto/riegeli_test.pb.go

Co-authored-by: Shahms King <shahms@google.com>
bazel-io pushed a commit that referenced this issue Sep 17, 2020
@Yannic @copybara-github
Upgrade protobuf to 3.13.0, part 2/3
c656e65 
This change does the actual upgrade of Protobuf. I'll send
a follow-up to remove the now-unused patch-file for `3.11.3`
when this has landed (and there is no risk of a rollback).

Working towards making Bazel compatible with #11694

Closes #12108.

PiperOrigin-RevId: 332196682
Yannic added a commit to Yannic/kythe that referenced this issue Sep 21, 2020
@Yannic
Use proto_library targets for skipping WKPs in C++ proto toolchains
94137b8 
This change migrates the `proto_lang_toolchain` targets to be compatible
with `--incompatible_blacklisted_protos_requires_proto_info`.

See bazelbuild/bazel#11694
@Yannic Yannic mentioned this issue Sep 21, 2020
Merged
shahms added a commit to kythe/kythe that referenced this issue Sep 22, 2020
@Yannic @shahms
Use proto_library targets for skipping WKPs in C++ proto toolchains (#…
78492c1 
…4690)

This change migrates the `proto_lang_toolchain` targets to be compatible
with `--incompatible_blacklisted_protos_requires_proto_info`.

See bazelbuild/bazel#11694

Co-authored-by: Shahms King <shahms@google.com>
Yannic added a commit to Yannic/core that referenced this issue Sep 23, 2020
@Yannic
Upgrade Protobuf to v3.13.0
d1de3c0 
This makes kythe compatible with
`--incompatible_blacklisted_protos_requires_proto_info`.
See bazelbuild/bazel#11694
@Yannic Yannic mentioned this issue Sep 23, 2020
Closed
@Yannic
Copy link
Contributor Author

Yannic commented Sep 23, 2020

This is ready for flipping once googlecloudrobotics/core#54 lands 🎉.

cloud-robotics-github-robot pushed a commit to googlecloudrobotics/core that referenced this issue Oct 2, 2020
@Yannic @copybara-github
Upgrade Protobuf to v3.13.0
e3c7ca4 
This makes Cloud Robotics Core compatible with
`--incompatible_blacklisted_protos_requires_proto_info`.
See bazelbuild/bazel#11694

Closes #54
#54

ORIGINAL_AUTHOR=Yannic Bonenberger <yannic@engflow.com>
GitOrigin-RevId: 19099d1
Change-Id: I65afc2eb92dd48f76d951bf6ad74a719ba1c9cc0
Yannic added a commit to Yannic/bazel that referenced this issue Oct 5, 2020
@Yannic
Flip --incompatible_blacklisted_protos_requires_proto_info
872c02c 
Fixes bazelbuild#11694
coeuvre pushed a commit to coeuvre/bazel that referenced this issue Oct 22, 2020
@Yannic @coeuvre
Upgrade protobuf to 3.13.0, part 1/3
14f9b17 
This change includes the third_party changes neccessary to upgrade
protobuf to 3.13.0.

Working towards making Bazel compatible with bazelbuild#11694

Closes bazelbuild#11807
coeuvre pushed a commit to coeuvre/bazel that referenced this issue Oct 22, 2020
@Yannic @coeuvre
Upgrade protobuf to 3.13.0, part 2/3
e887418 
This change does the actual upgrade of Protobuf. I'll send
a follow-up to remove the now-unused patch-file for `3.11.3`
when this has landed (and there is no risk of a rollback).

Working towards making Bazel compatible with bazelbuild#11694

Closes bazelbuild#12108.

PiperOrigin-RevId: 332196682
coeuvre pushed a commit to coeuvre/bazel that referenced this issue Oct 22, 2020
@Yannic @coeuvre
Upgrade protobuf to 3.13.0, part 1/3
4a4b9b3 
This change includes the third_party changes neccessary to upgrade
protobuf to 3.13.0.

Working towards making Bazel compatible with bazelbuild#11694

Closes bazelbuild#11807
coeuvre pushed a commit to coeuvre/bazel that referenced this issue Oct 22, 2020
@Yannic @coeuvre
Upgrade protobuf to 3.13.0, part 2/3
f17e1c9 
This change does the actual upgrade of Protobuf. I'll send
a follow-up to remove the now-unused patch-file for `3.11.3`
when this has landed (and there is no risk of a rollback).

Working towards making Bazel compatible with bazelbuild#11694

Closes bazelbuild#12108.

PiperOrigin-RevId: 332196682
comius pushed a commit to comius/bazel that referenced this issue Oct 28, 2020
@Yannic @comius
Flip --incompatible_blacklisted_protos_requires_proto_info
e7d11db 
Fixes bazelbuild#11694
@comius comius mentioned this issue Oct 28, 2020
Closed
Yannic added a commit to Yannic/bazel that referenced this issue Oct 28, 2020
@Yannic
Flip --incompatible_blacklisted_protos_requires_proto_info
92593d2 
Fixes bazelbuild#11694
@Yannic Yannic mentioned this issue Jan 23, 2021
Open
@owent owent mentioned this issue Apr 8, 2021
Closed
@Stonepia Stonepia mentioned this issue May 25, 2021
Closed
suiliangchu pushed a commit to suiliangchu/cartographer that referenced this issue Oct 9, 2022
@Yannic
Upgrade Protobuf to v3.13.0 (#1746)
4732e7d 
This makes cartographer compatible with
`--incompatible_blacklisted_protos_requires_proto_info`.
See bazelbuild/bazel#11694

Signed-off-by: Yannic Bonenberger <contact@yannic-bonenberger.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yannic Yannic

Labels
incompatible-change Incompatible/breaking change team-Rules-Server Issues for serverside rules included with Bazel type: process untriaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Flip --incompatible_blacklisted_protos_requires_proto_info Yannic/bazel
Pull/12037 comius/bazel
6 participants
@katre @meisterT @laurentlb @aiuto @gregestren @Yannic