Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip --incompatible_blacklisted_protos_requires_proto_info #12037

Closed
wants to merge 3 commits into from

Conversation

Yannic
Copy link
Contributor

@Yannic Yannic commented Sep 2, 2020

Fixes #11694

@lberki
Copy link
Contributor

lberki commented Sep 2, 2020

What about the big pile of failing presubmits?

@Yannic
Copy link
Contributor Author

Yannic commented Sep 17, 2020

The Bazel repo wasn't ready for flipping the flag yet, upgrading Protobuf to 3.13.0 fixed that (#12108). bazel_proto_library_test is still failing on RBE (but not anywhere else). Not sure why yet.

@lberki Could you already run this through internal presubmit to see whether there's anything needed before we can merge it for Bazel 4.0?

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Oct 5, 2020
@Yannic
Copy link
Contributor Author

Yannic commented Oct 5, 2020

(sorry this requested so many reviewers, I made a mistake when rebase the change)

@bazel-io bazel-io closed this in 53705f6 Nov 2, 2020
@Yannic Yannic mentioned this pull request Nov 14, 2020
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants