-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing dependency declaration with path mapping #23681
Labels
P1
I'll work on this now. (Assignee required)
team-Configurability
platforms, toolchains, cquery, select(), config transitions
team-Rules-CPP
Issues for C++ rules
type: bug
Comments
fmeum
added
type: bug
P1
I'll work on this now. (Assignee required)
team-Configurability
platforms, toolchains, cquery, select(), config transitions
team-Rules-CPP
Issues for C++ rules
labels
Sep 19, 2024
@keith I added integration test coverage for headers from an external repo, but everything works there. Could you try to build a reproducer for me? |
Here's a repro, I didn't try to isolate more than using this rules_foreign_cc target |
This may be of help #21718 (comment) |
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this issue
Sep 24, 2024
Fixes header inclusion errors with path mapping when including a header that is a non-direct child of a tree artifact. Fixes bazelbuild#23681 Closes bazelbuild#23690. PiperOrigin-RevId: 678118252 Change-Id: I37f4d5e8827785b291b5655967afba8f2a673df2
github-merge-queue bot
pushed a commit
that referenced
this issue
Sep 26, 2024
…discovery (#23745) Fixes header inclusion errors with path mapping when including a header that is a non-direct child of a tree artifact. Fixes #23681 Closes #23690. PiperOrigin-RevId: 678118252 Change-Id: I37f4d5e8827785b291b5655967afba8f2a673df2 Commit 9cfffdf Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
P1
I'll work on this now. (Assignee required)
team-Configurability
platforms, toolchains, cquery, select(), config transitions
team-Rules-CPP
Issues for C++ rules
type: bug
I was testing this out with #23630 applied, I got pretty far but I hit this issue:
Where the header here is from a rules_foreign_cc target:
It might be relevant that I access it through an alias (although removing that doesn't help):
Are you tracking this one?
Originally posted by @keith in #22658 (comment)
The text was updated successfully, but these errors were encountered: