Path map non-direct children of tree artifacts during header discovery #23690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes header inclusion errors with path mapping when including a header that is not a direct child of a tree artifact.
|
@bazel-io fork 7.4.0 |
github-actions
bot
added
team-Rules-CPP
|
FYI @keith |
|
verified on our project, thanks! |
comius
approved these changes
Sep 23, 2024
comius
added
awaiting-PR-merge
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Sep 24, 2024
Fixes header inclusion errors with path mapping when including a header that is a non-direct child of a tree artifact. Fixes bazelbuild#23681 Closes bazelbuild#23690. PiperOrigin-RevId: 678118252 Change-Id: I37f4d5e8827785b291b5655967afba8f2a673df2
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 26, 2024
…discovery (#23745) Fixes header inclusion errors with path mapping when including a header that is a non-direct child of a tree artifact. Fixes #23681 Closes #23690. PiperOrigin-RevId: 678118252 Change-Id: I37f4d5e8827785b291b5655967afba8f2a673df2 Commit 9cfffdf Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes header inclusion errors with path mapping when including a header that is a non-direct child of a tree artifact.
Fixes #23681