Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.4.0] Mark tool runfiles as such in expanded execution log #23734

Closed
bazel-io opened this issue Sep 24, 2024 · 3 comments
Closed

[7.4.0] Mark tool runfiles as such in expanded execution log #23734

bazel-io opened this issue Sep 24, 2024 · 3 comments
Milestone
7.4.0 release blo...

Comments

@bazel-io
Copy link
Member

Forked from #23702
@bazel-io bazel-io added this to the 7.4.0 release blockers milestone Sep 24, 2024
@bazel-io
Copy link
Member Author

Cherry-pick was attempted but there were merge conflicts in the following file(s). Please resolve manually.

src/main/java/com/google/devtools/build/lib/exec/BUILD
src/main/java/com/google/devtools/build/lib/exec/ExpandedSpawnLogContext.java
src/test/java/com/google/devtools/build/lib/exec/SpawnLogContextTestBase.java

cc: @bazelbuild/triage

@fmeum
Copy link
Collaborator

fmeum commented Sep 27, 2024

I'm not sure how to cherry-pick this and the format is deprecated anyway.

@fmeum fmeum closed this as not planned Won't fix, can't repro, duplicate, stale Sep 27, 2024
@fmeum fmeum reopened this Sep 27, 2024
@fmeum fmeum mentioned this issue Sep 28, 2024
Merged
@iancha1992
Copy link
Member

Cherry-picked in #23713

bazel-io pushed a commit to bazel-io/bazel that referenced this issue Sep 30, 2024
@fmeum
[7.4.0] Compact execution log improvements (bazelbuild#23713)
53b04fe 
Cherry-picks the following changes:

* Optimize representation of runfiles in compact execution log (bazelbuild#23321)
* Keep runfiles tree IDs in memory for multiple test attempts (bazelbuild#23703)
* Fix naming inconsistency in `spawn.proto` (bazelbuild#23706)
* Mark tool runfiles as such in expanded execution log (bazelbuild#23702)

The cherry-picks required introducing a `Map<Artifact, RunfilesTree>`
shim to `RunfilesSupplier` that matches the Bazel 8 way of obtaining a
`RunfilesTree` from a runfiles middleman via `InputMetadataProvider`.

Closes bazelbuild#23683 
Closes bazelbuild#23710
Closes bazelbuild#23711
Closes bazelbuild#23734
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.4.0 release blockers
Development

No branches or pull requests
3 participants
@fmeum @bazel-io @iancha1992