Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix naming inconsistency in spawn.proto #23706

Closed
wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Sep 22, 2024

No description provided.

@fmeum fmeum requested a review from tjgq September 22, 2024 09:16
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Sep 22, 2024
@tjgq tjgq added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Sep 22, 2024
@fmeum
Copy link
Collaborator Author

fmeum commented Sep 23, 2024

@bazel-io fork 7.4.0

@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Sep 23, 2024
@fmeum fmeum deleted the spawn-log-rename branch September 23, 2024 09:35
iancha1992 pushed a commit that referenced this pull request Sep 24, 2024
Closes #23706.

PiperOrigin-RevId: 677697462
Change-Id: I3e7d6d856881c5208df86011f165389db744abf0
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Sep 30, 2024
Cherry-picks the following changes:

* Optimize representation of runfiles in compact execution log (bazelbuild#23321)
* Keep runfiles tree IDs in memory for multiple test attempts (bazelbuild#23703)
* Fix naming inconsistency in `spawn.proto` (bazelbuild#23706)
* Mark tool runfiles as such in expanded execution log (bazelbuild#23702)

The cherry-picks required introducing a `Map<Artifact, RunfilesTree>`
shim to `RunfilesSupplier` that matches the Bazel 8 way of obtaining a
`RunfilesTree` from a runfiles middleman via `InputMetadataProvider`.

Closes bazelbuild#23683 
Closes bazelbuild#23710
Closes bazelbuild#23711
Closes bazelbuild#23734
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants