Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visibility not working with @my_repository references #7180

Closed
sergiocampama opened this issue Jan 18, 2019 · 4 comments
Closed

Visibility not working with @my_repository references #7180

sergiocampama opened this issue Jan 18, 2019 · 4 comments
Assignees
@dkelmer
Labels
P2 We'll consider working on this in future. (Assignee optional) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: bug

Comments

@sergiocampama
Copy link
Contributor

Description of the problem / feature request:

Visibility is not properly processed when using the @my_repository syntax for referencing targets. I'd expect that I can reference targets with both // and @my_repository syntax but it seems the latter trips up visibility processing.

Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

Check out https://github.com/sergiocampama/visibility_repro_case
bazel build works should succeed, but bazel build does_not_work doesn't.

What operating system are you running Bazel on?

macOS Mojave

What's the output of bazel info release?

release 0.21.0
@clintharrison
Copy link
Contributor

I believe this is fixed by --experimental_remap_main_repo (soon to be #7130) and this issue itself is a duplicate of #3115?

sergiocampama pushed a commit to bazelbuild/apple_support that referenced this issue Jan 18, 2019
@thomasvl @sergiocampama
Bazel trips up on visibility with @repository references.
73045e0 
Avoiding bazelbuild/bazel#7180

RELNOTES: None
PiperOrigin-RevId: 229942617
sergiocampama pushed a commit to bazelbuild/apple_support that referenced this issue Jan 18, 2019
@thomasvl @sergiocampama
Bazel trips up on visibility with @repository references.
77c9d53 
Avoiding bazelbuild/bazel#7180

RELNOTES: None
PiperOrigin-RevId: 229942617
@jin jin added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. untriaged labels Jan 18, 2019
allevato pushed a commit to bazelbuild/rules_swift that referenced this issue Jan 28, 2019
@thomasvl @allevato
Bazel trips up on visibility with @repository references.
ad70855 
Avoiding bazelbuild/bazel#7180

RELNOTES: None
PiperOrigin-RevId: 229971482
@allevato allevato mentioned this issue Jan 28, 2019
Merged
allevato pushed a commit to bazelbuild/rules_swift that referenced this issue Jan 28, 2019
@thomasvl @allevato
Bazel trips up on visibility with @repository references.
1b9a353 
Avoiding bazelbuild/bazel#7180

RELNOTES: None
PiperOrigin-RevId: 229971482
@dslomov dslomov added type: bug P2 We'll consider working on this in future. (Assignee optional) and removed untriaged labels Jan 31, 2019
@dslomov
Copy link
Contributor

dslomov commented Jan 31, 2019

@dkelmer could you validate that it all works now after repository remapping is shipped?

@dkelmer
Copy link
Contributor

dkelmer commented Feb 4, 2019

bazel build does_not_work --experimental_remap_main_repo builds successfully with bazel 0.22. The flag will be called --incompatible_remap_main_repo in the next release and become the default in the release following that.

@dkelmer dkelmer closed this as completed Feb 4, 2019
@dkelmer
Copy link
Contributor

dkelmer commented Feb 4, 2019

Thanks for the simple repro case btw :)

This was referenced Nov 18, 2019
Closed
Closed
@philwo philwo added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Jun 15, 2020
@philwo philwo removed the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Nov 29, 2021
tymurmustafaiev pushed a commit to tymurmustafaiev/rules_swift that referenced this issue Jul 19, 2023
@thomasvl @allevato
Bazel trips up on visibility with @repository references.
c8c260e 
Avoiding bazelbuild/bazel#7180

RELNOTES: None
PiperOrigin-RevId: 229971482
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dkelmer dkelmer

Labels
P2 We'll consider working on this in future. (Assignee optional) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@clintharrison @jin @philwo @sergiocampama @dslomov @dkelmer