Skip to content

Commit

Permalink
Bazel trips up on visibility with @repository references.
Browse files Browse the repository at this point in the history
Avoiding bazelbuild/bazel#7180

RELNOTES: None
PiperOrigin-RevId: 229971482
  • Loading branch information
thomasvl authored and allevato committed Jan 28, 2019
1 parent 001736d commit ad70855
Show file tree
Hide file tree
Showing 13 changed files with 15 additions and 15 deletions.
4 changes: 2 additions & 2 deletions BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ filegroup(
testonly = 1,
srcs = [
"WORKSPACE",
"@build_bazel_rules_swift//swift:for_bazel_tests",
"@build_bazel_rules_swift//tools:for_bazel_tests",
"//swift:for_bazel_tests",
"//tools:for_bazel_tests",
],
)
2 changes: 1 addition & 1 deletion examples/apple/objc_interop/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# platforms.

load(
"@build_bazel_rules_swift//swift:swift.bzl",
"//swift:swift.bzl",
"swift_binary",
"swift_library",
)
Expand Down
2 changes: 1 addition & 1 deletion examples/xplatform/c_from_swift/BUILD
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
load("@build_bazel_rules_swift//swift:swift.bzl", "swift_binary", "swift_library")
load("//swift:swift.bzl", "swift_binary", "swift_library")

licenses(["notice"])

Expand Down
2 changes: 1 addition & 1 deletion examples/xplatform/dispatch/BUILD
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
load("@build_bazel_rules_swift//swift:swift.bzl", "swift_binary")
load("//swift:swift.bzl", "swift_binary")

licenses(["notice"])

Expand Down
2 changes: 1 addition & 1 deletion examples/xplatform/hello_world/BUILD
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
load("@build_bazel_rules_swift//swift:swift.bzl", "swift_binary")
load("//swift:swift.bzl", "swift_binary")

licenses(["notice"])

Expand Down
2 changes: 1 addition & 1 deletion examples/xplatform/proto/BUILD
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
load(
"@build_bazel_rules_swift//swift:swift.bzl",
"//swift:swift.bzl",
"swift_binary",
"swift_proto_library",
)
Expand Down
2 changes: 1 addition & 1 deletion examples/xplatform/xctest/BUILD
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
load("@build_bazel_rules_swift//swift:swift.bzl", "swift_test")
load("//swift:swift.bzl", "swift_test")

licenses(["notice"])

Expand Down
2 changes: 1 addition & 1 deletion swift/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ filegroup(
name = "for_bazel_tests",
testonly = 1,
srcs = glob(["**"]) + [
"@build_bazel_rules_swift//swift/internal:for_bazel_tests",
"//swift/internal:for_bazel_tests",
],
visibility = [
"//:__pkg__",
Expand Down
2 changes: 1 addition & 1 deletion swift/internal/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@ filegroup(
"@bazel_tools//tools/build_defs/cc:action_names_test_files",
],
visibility = [
"@build_bazel_rules_swift//swift:__pkg__",
"//swift:__pkg__",
],
)
4 changes: 2 additions & 2 deletions tools/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ filegroup(
name = "for_bazel_tests",
testonly = 1,
srcs = glob(["**"]) + [
"@build_bazel_rules_swift//tools/mkdir_and_run:for_bazel_tests",
"@build_bazel_rules_swift//tools/wrappers:for_bazel_tests",
"//tools/mkdir_and_run:for_bazel_tests",
"//tools/wrappers:for_bazel_tests",
],
visibility = [
"//:__pkg__",
Expand Down
2 changes: 1 addition & 1 deletion tools/mkdir_and_run/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@ filegroup(
testonly = 1,
srcs = glob(["**"]),
visibility = [
"@build_bazel_rules_swift//tools:__pkg__",
"//tools:__pkg__",
],
)
2 changes: 1 addition & 1 deletion tools/wrappers/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@ filegroup(
testonly = 1,
srcs = glob(["**"]),
visibility = [
"@build_bazel_rules_swift//tools:__pkg__",
"//tools:__pkg__",
],
)
2 changes: 1 addition & 1 deletion tools/xctest_runner/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@ filegroup(
testonly = 1,
srcs = glob(["**"]),
visibility = [
"@build_bazel_rules_swift//tools:__pkg__",
"//tools:__pkg__",
],
)

0 comments on commit ad70855

Please sign in to comment.