Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force loading the Protobuf rules from the rules_proto repo #8891

Closed
Yannic opened this issue Jul 15, 2019 · 1 comment
Closed

Force loading the Protobuf rules from the rules_proto repo #8891

Yannic opened this issue Jul 15, 2019 · 1 comment
Assignees
@Yannic
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-Rules-Server Issues for serverside rules included with Bazel type: process

Comments

@Yannic
Copy link
Contributor

Yannic commented Jul 15, 2019 •
edited by hlopko
Loading

This big breaking change will force users of the Protobuf rules to use the Starlark rules from the @rules_proto repository. The rules there are currently only wrappers around native rules, but they will be rewritten in the future.

Design doc: https://docs.google.com/document/d/1Wai_okIK_NnhNJZai5nkTUvZVHdV5pp1YwNLFtWwpC4/edit?ts=5d2c8077
@iirina iirina added team-Rules-Server Issues for serverside rules included with Bazel untriaged labels Jul 16, 2019
Yannic added a commit to Yannic/rules_proto_bazelbuild that referenced this issue Jul 18, 2019
@Yannic
Add migration tag to rules and export some more native symbols
b9e633e 
This change is in preparation for `--incompatible_load_proto_rules_from_bzl`.

See bazelbuild/bazel#8891
This was referenced Jul 18, 2019
Merged
Open
@aaliddell aaliddell mentioned this issue Aug 2, 2019
Closed
@scentini scentini added P1 I'll work on this now. (Assignee required) and removed untriaged labels Aug 7, 2019
@lberki lberki added P3 We're not considering working on this, but happy to review a PR. (No assignee) type: process and removed P1 I'll work on this now. (Assignee required) labels Nov 18, 2020
@jonmeow jonmeow mentioned this issue Mar 23, 2022
Merged
@sgowroji sgowroji added the stale Issues or PRs that are stale (no activity for 30 days) label Feb 15, 2023
@sgowroji
Copy link
Member

Hi there! We're doing a clean up of old issues and will be closing this one. Please reopen if you’d like to discuss anything further. We’ll respond as soon as we have the bandwidth/resources to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yannic Yannic

Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) stale Issues or PRs that are stale (no activity for 30 days) team-Rules-Server Issues for serverside rules included with Bazel type: process
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@iirina @lberki @Yannic @scentini @sgowroji