incompatible_load_proto_rules_from_bzl: load the Protobuf rules from @rules_proto #8922

Yannic · 2019-07-18T10:26:45Z

Flag: --incompatible_load_proto_rules_from_bzl
Available since: 0.29
Will be flipped in: TBD
Tracking issue: #8891

proto_library and proto_lang_toolchain have to be loaded from @rules_proto.

For example, if you are usingproto_library, add the following load statement to your BUILD/bzl file.

load("@rules_proto//proto:defs.bzl", "proto_library")

You can use the following buildifier command to automate the changes to your BUILD/bzl files:

buildifier --lint=fix --warnings=native-proto <path/to/BUILD>

You will have to add proto_library to your WORKSPACE file as well:

load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
http_archive(
    name = "rules_proto",
    sha256 = "602e7161d9195e50246177e7c55b2f39950a9cf7366f74ed5f22fd45750cd208",
    strip_prefix = "rules_proto-97d8af4dc474595af3900dd85cb3a29ad28cc313",
    urls = [
        "https://mirror.bazel.build/github.com/bazelbuild/rules_proto/archive/97d8af4dc474595af3900dd85cb3a29ad28cc313.tar.gz",
        "https://github.com/bazelbuild/rules_proto/archive/97d8af4dc474595af3900dd85cb3a29ad28cc313.tar.gz",
    ],
)
load("@rules_proto//proto:repositories.bzl", "rules_proto_dependencies", "rules_proto_toolchains")
rules_proto_dependencies()
rules_proto_toolchains()

The text was updated successfully, but these errors were encountered:

RELNOTES: --incompatible_load_proto_rules_from_bzl was added to forbid loading the native proto rules directly. See more on tracking issue bazelbuild#8922

Yannic · 2019-07-19T10:49:27Z

@iirina Can you add the labels breaking-change-1.0, incompatible-change, migration-ready, and migration-0.29 per https://docs.bazel.build/versions/0.28.0/backward-compatibility.html#github-labels? Thanks!

iirina · 2019-07-19T10:51:52Z

@Yannic done! Thanks!

RELNOTES: --incompatible_load_proto_rules_from_bzl was added to forbid loading the native proto rules directly. See more on tracking issue #8922 Closes #8923. PiperOrigin-RevId: 259294885

DO NOT SUBMIT until Bazel 0.29 was cut. RELNOTES: The flag --incompatible_load_proto_rules_from_bzl from_bzl has been flipped. Fixes bazelbuild#8922

dslomov · 2019-08-05T13:09:19Z

Will the migration tooling be available to do the migration? (based on buildifier)

Yannic · 2019-08-05T13:19:03Z

Yes, a buildifier fix has been added in bazelbuild/buildtools#674

DO NOT SUBMIT until Bazel 0.29 was cut. RELNOTES: The flag --incompatible_load_proto_rules_from_bzl from_bzl has been flipped. Fixes bazelbuild#8922

Yannic · 2019-08-22T19:37:17Z

This flag won't be flipped in Bazel 1.0. Could someone remove breaking-change-1.0?

Baseline: 6c5ef53 Cherry picks: + 338829f: Fix retrying of SocketTimeoutExceptions in HttpConnector + 14651cd: Fallback to next urls if download fails in HttpDownloader + b7d300c: Fix incorrect stdout/stderr in remote action cache. Fixes #9072 + 9602176: Automated rollback of commit 0f0a0d5. + da557f9: Windows: fix "bazel run" argument quoting + ef8b6f6: Return JavaInfo from java proto aspects. + 209175f: Revert back to the old behavior of not creating a proto source root for generated .proto files. + 644060b: Fix PatchUtil for parsing special patch format + 067040d: Put the removal of the legacy repository-relative proto path behind the --incompatible_generated_protos_in_virtual_imports flag. + 76ed014: repository mapping lookup: convert to canonical name first Important changes: - rule_test: fix Bazel 0.27 regression ("tags" attribute was ingored, #8723 - Adds --incompatible_enable_execution_transition, which enables incremental migration of host attributes to exec attributes. - objc_proto_library rule has been deleted from Bazel. - repository_ctx.read is no longer restricted to files in the repository contructed. - tags 'no-remote', 'no-cache', 'no-remote-cache', 'no-remote-exec', 'no-sandbox' are propagated now to the actions from targets when '--ncompatible_allow_tags_propagation' flag set to true. See #8830. - Adds flag --//tools/build_defs/pkg:incompatible_no_build_defs_pkg. This flag turns off the rules //tools/build_defs/pkg:{pkg_deb, pkg_rpm, pkg_tar}. - The Android NDK is now integrated with toolchains. To use them, pass the `--extra_toolchains=@androidndk//:all` flag or register them in your WORKSPACE with `register_toolchains("@androidndk//:all")`. - Stdout and stderr are checked to determine if output is going to a terminal. `--is_stderr_atty` is deprecated and `--isatty` is undeprecated. - --incompatible_load_proto_rules_from_bzl was added to forbid loading the native proto rules directly. See more on tracking issue #8922 - Docker Sandbox now respects remote_default_platform_properties - pkg_deb, pkg_rpm & pkg_tar deprecation plan announced in the documentation. - The new java_tools release: * fixes #8614 * exposes a new toolchain `@java_tools//:prebuilt_toolchain` which is using all the pre-built tools, including singlejar and ijar, even on remote execution. This toolchain should be used only when host and execution platform are the same, otherwise the binaries will not work on the execution platform. - java_common.compile supports specifying annotation_processor_additional_inputs and annotation_processor_additional_outputs for the Java compilation action for supporting annotation processors that consume or produce artifacts. Fixes #6415 - There is now documentation on optimizing Android app build performance. Read it at https://docs.bazel.build/versions/0.29.0/android-build-performance .html - Execution log now respects --remote_default_platform_properties - Include a link to the relevant documenation on transitive Python version errors. - New incompatible flag --incompatible_disable_target_provider_fields removes the ability (in Starlark) to access a target's providers via the field syntax (for example, `ctx.attr.dep.my_provider`). The provider-key syntax should be used instead (for example, `ctx.attr.dep[MyProvider]`). See #9014 for details. - A new platform exec_properties is added to replace remote_execution_properties. - Added --incompatible_load_python_rules_from_bzl, which will be flipped in Bazel 1.0. See #9006. - add --break_build_on_parallel_dex2oat_failure to shortcut tests on dex2oat errors This release contains contributions from many people at Google, as well as Alexander Ilyin, Arek Sredzki, Artem Zinnatullin, Benjamin Peterson, Fan Wu, John Millikin, Loo Rong Jie, Marwan Tammam, Oscar Bonilla, Peter Mounce, Sergio Rodriguez Orellana, Takeo Sawada, and Yannic Bonenberger.

Baseline: 6c5ef53 Cherry picks: + 338829f: Fix retrying of SocketTimeoutExceptions in HttpConnector + 14651cd: Fallback to next urls if download fails in HttpDownloader + b7d300c: Fix incorrect stdout/stderr in remote action cache. Fixes bazelbuild#9072 + 9602176: Automated rollback of commit 0f0a0d5. + da557f9: Windows: fix "bazel run" argument quoting + ef8b6f6: Return JavaInfo from java proto aspects. + 209175f: Revert back to the old behavior of not creating a proto source root for generated .proto files. + 644060b: Fix PatchUtil for parsing special patch format + 067040d: Put the removal of the legacy repository-relative proto path behind the --incompatible_generated_protos_in_virtual_imports flag. + 76ed014: repository mapping lookup: convert to canonical name first Important changes: - rule_test: fix Bazel 0.27 regression ("tags" attribute was ingored, bazelbuild#8723 - Adds --incompatible_enable_execution_transition, which enables incremental migration of host attributes to exec attributes. - objc_proto_library rule has been deleted from Bazel. - repository_ctx.read is no longer restricted to files in the repository contructed. - tags 'no-remote', 'no-cache', 'no-remote-cache', 'no-remote-exec', 'no-sandbox' are propagated now to the actions from targets when '--ncompatible_allow_tags_propagation' flag set to true. See bazelbuild#8830. - Adds flag --//tools/build_defs/pkg:incompatible_no_build_defs_pkg. This flag turns off the rules //tools/build_defs/pkg:{pkg_deb, pkg_rpm, pkg_tar}. - The Android NDK is now integrated with toolchains. To use them, pass the `--extra_toolchains=@androidndk//:all` flag or register them in your WORKSPACE with `register_toolchains("@androidndk//:all")`. - Stdout and stderr are checked to determine if output is going to a terminal. `--is_stderr_atty` is deprecated and `--isatty` is undeprecated. - --incompatible_load_proto_rules_from_bzl was added to forbid loading the native proto rules directly. See more on tracking issue bazelbuild#8922 - Docker Sandbox now respects remote_default_platform_properties - pkg_deb, pkg_rpm & pkg_tar deprecation plan announced in the documentation. - The new java_tools release: * fixes bazelbuild#8614 * exposes a new toolchain `@java_tools//:prebuilt_toolchain` which is using all the pre-built tools, including singlejar and ijar, even on remote execution. This toolchain should be used only when host and execution platform are the same, otherwise the binaries will not work on the execution platform. - java_common.compile supports specifying annotation_processor_additional_inputs and annotation_processor_additional_outputs for the Java compilation action for supporting annotation processors that consume or produce artifacts. Fixes bazelbuild#6415 - There is now documentation on optimizing Android app build performance. Read it at https://docs.bazel.build/versions/0.29.0/android-build-performance .html - Execution log now respects --remote_default_platform_properties - Include a link to the relevant documenation on transitive Python version errors. - New incompatible flag --incompatible_disable_target_provider_fields removes the ability (in Starlark) to access a target's providers via the field syntax (for example, `ctx.attr.dep.my_provider`). The provider-key syntax should be used instead (for example, `ctx.attr.dep[MyProvider]`). See bazelbuild#9014 for details. - A new platform exec_properties is added to replace remote_execution_properties. - Added --incompatible_load_python_rules_from_bzl, which will be flipped in Bazel 1.0. See bazelbuild#9006. - add --break_build_on_parallel_dex2oat_failure to shortcut tests on dex2oat errors This release contains contributions from many people at Google, as well as Alexander Ilyin, Arek Sredzki, Artem Zinnatullin, Benjamin Peterson, Fan Wu, John Millikin, Loo Rong Jie, Marwan Tammam, Oscar Bonilla, Peter Mounce, Sergio Rodriguez Orellana, Takeo Sawada, and Yannic Bonenberger.

Starting soon, Protobuf rules will require explicit load statements bazelbuild/bazel#8922

limdor · 2021-11-09T13:02:19Z

What is the status of this flag, it is saying will be flipped TBD but breaking change 5.0. Is it flipped in Bazel 5?

lberki · 2021-11-09T13:10:32Z

@philwo I assume we are not flipping this in 5.0 since we decided to go with builtin Starlark rules instead for the time being?

lberki · 2021-11-09T13:10:38Z

/cc @comius

Yannic · 2021-11-09T13:14:48Z

I don't think it's ready for flipping in 5.0 (would like to do it eventually though)

comius · 2021-11-09T17:28:37Z

Absolutely, not flipping in 5.0. I removed the label on the issue.

github-actions · 2023-06-26T01:34:18Z

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 1+ years. It will be closed in the next 14 days unless any other activity occurs or one of the following labels is added: "not stale", "awaiting-bazeler". Please reach out to the triage team (@bazelbuild/triage) if you think this issue is still relevant or you are interested in getting the issue resolved.

Yannic mentioned this issue Jul 18, 2019

Add incompatible flag to forbid loading the native Protobuf rules #8923

Closed

iirina added P2 We'll consider working on this in future. (Assignee optional) team-Rules-Server Issues for serverside rules included with Bazel labels Jul 18, 2019

iirina added breaking-change-1.0 incompatible-change Incompatible/breaking change labels Jul 19, 2019

This was referenced Jul 23, 2019

Add native-proto fix to buildifier bazelbuild/buildtools#674

Merged

[bazel] Add fixes for --incompatible_load_{cc,java,proto}_rules_from_bzl protocolbuffers/protobuf#6432

Merged

Yannic added a commit to Yannic/bazel that referenced this issue Jul 25, 2019

Flip --incompatible_load_proto_rules_from_bzl

4f3fb1d

DO NOT SUBMIT until Bazel 0.29 was cut. RELNOTES: The flag --incompatible_load_proto_rules_from_bzl from_bzl has been flipped. Fixes bazelbuild#8922

Yannic mentioned this issue Jul 25, 2019

Flip --incompatible_load_proto_rules_from_bzl #8987

Closed

katre removed the migration-ready label Aug 2, 2019

Yannic added a commit to Yannic/bazel that referenced this issue Aug 19, 2019

Flip --incompatible_load_proto_rules_from_bzl

aaa507f

DO NOT SUBMIT until Bazel 0.29 was cut. RELNOTES: The flag --incompatible_load_proto_rules_from_bzl from_bzl has been flipped. Fixes bazelbuild#8922

iirina removed the breaking-change-1.0 label Aug 23, 2019

meisterT added migration-1.0 labels Oct 14, 2019

hlopko assigned Yannic Oct 15, 2019

hlopko added the breaking-change-2.0 label Oct 15, 2019

Yannic added a commit to Yannic/grpc that referenced this issue Oct 24, 2019

[bazel] Add fixes for --incompatible_load_proto_rules_from_bzl

f328ac6

Starting soon, Protobuf rules will require explicit load statements bazelbuild/bazel#8922

This was referenced Oct 24, 2019

[bazel] Add fixes for --incompatible_load_proto_rules_from_bzl grpc/grpc#20783

Merged

Add config for Bazel CI grpc/grpc-web#665

Merged

philwo added the migration-4.0 label Nov 18, 2020

lberki self-assigned this Nov 18, 2020

lberki added the type: process label Nov 25, 2020

comius removed the breaking-change-5.0 label Nov 9, 2021

comius assigned comius and unassigned lberki Nov 9, 2021

sgowroji removed migration-2.0 labels Apr 21, 2022

github-actions bot added stale Issues or PRs that are stale (no activity for 30 days) and removed stale Issues or PRs that are stale (no activity for 30 days) labels Jun 26, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

incompatible_load_proto_rules_from_bzl: load the Protobuf rules from @rules_proto #8922

incompatible_load_proto_rules_from_bzl: load the Protobuf rules from @rules_proto #8922

Yannic commented Jul 18, 2019 •

edited

Loading

Yannic commented Jul 19, 2019

iirina commented Jul 19, 2019

dslomov commented Aug 5, 2019

Yannic commented Aug 5, 2019

Yannic commented Aug 22, 2019

limdor commented Nov 9, 2021

lberki commented Nov 9, 2021

lberki commented Nov 9, 2021

Yannic commented Nov 9, 2021

comius commented Nov 9, 2021

github-actions bot commented Jun 26, 2023

incompatible_load_proto_rules_from_bzl: load the Protobuf rules from @rules_proto #8922

incompatible_load_proto_rules_from_bzl: load the Protobuf rules from @rules_proto #8922

Comments

Yannic commented Jul 18, 2019 • edited Loading

Yannic commented Jul 19, 2019

iirina commented Jul 19, 2019

dslomov commented Aug 5, 2019

Yannic commented Aug 5, 2019

Yannic commented Aug 22, 2019

limdor commented Nov 9, 2021

lberki commented Nov 9, 2021

lberki commented Nov 9, 2021

Yannic commented Nov 9, 2021

comius commented Nov 9, 2021

github-actions bot commented Jun 26, 2023

Yannic commented Jul 18, 2019 •

edited

Loading