Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow hyphen char in workspace name #11838

Closed
wants to merge 1 commit into from
Closed

Allow hyphen char in workspace name #11838

wants to merge 1 commit into from

Conversation

davido
Copy link
Contributor

@davido davido commented Jul 25, 2020 •
edited
Loading

Closes #11837.

@davido davido force-pushed the allow-hyphen-char-in-workspace-name-again branch from 460949d to 34771a1 Compare July 25, 2020 15:48
@oquenchil oquenchil added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Jul 28, 2020
@Gromba
Copy link

Gromba commented Aug 4, 2020

Could you also add support for the . character?

The local_repository rule uses this regex, but says it allows a '.' character, which is currently does not:
local_repository rule //external:shared.name's name field must be a legal workspace name; workspace names may contain only A-Z, a-z, 0-9, '-', '_' and '.'

@aiuto aiuto mentioned this pull request Aug 11, 2020
Closed
@meisterT meisterT requested a review from laurentlb August 12, 2020 18:41
laurentlb
laurentlb approved these changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@laurentlb laurentlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bazel-io bazel-io closed this in e574d55 Aug 12, 2020
aiuto pushed a commit that referenced this pull request Aug 12, 2020
@davido @aiuto
Allow hyphen char in workspace name
26bdafb 
Closes #11837.

Closes #11838.

PiperOrigin-RevId: 326286694
@davido davido deleted the allow-hyphen-char-in-workspace-name-again branch August 13, 2020 04:56
@or-shachar or-shachar mentioned this pull request Aug 13, 2020
Closed
aiuto pushed a commit that referenced this pull request Aug 18, 2020
@davido @aiuto
Allow hyphen char in workspace name
4b4fb92 
Closes #11837.

Closes #11838.

PiperOrigin-RevId: 326286694
aiuto pushed a commit that referenced this pull request Aug 20, 2020
@davido @aiuto
Allow hyphen char in workspace name
d4049f6 
Closes #11837.

Closes #11838.

PiperOrigin-RevId: 326286694
michaeleisel pushed a commit to michaeleisel/bazel that referenced this pull request Sep 3, 2020
@davido @aiuto
Allow hyphen char in workspace name
30c0287 
Closes bazelbuild#11837.

Closes bazelbuild#11838.

PiperOrigin-RevId: 326286694
aiuto pushed a commit that referenced this pull request Sep 12, 2020
@davido @aiuto
Allow hyphen char in workspace name
1d9ea23 
Closes #11837.

Closes #11838.

PiperOrigin-RevId: 326286694
aiuto pushed a commit that referenced this pull request Sep 25, 2020
@davido @aiuto
Allow hyphen char in workspace name
6ae5599 
Closes #11837.

Closes #11838.

PiperOrigin-RevId: 326286694
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurentlb laurentlb laurentlb approved these changes

Assignees
No one assigned
Labels
cla: yes team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"foo-bar is not a legal workspace name" error is reported on Bazel@HEAD
5 participants
@davido @Gromba @laurentlb @googlebot @oquenchil