New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow dot char in workspace name #11941

Closed

or-shachar wants to merge 1 commit into bazelbuild:master from or-shachar:patch-5

Contributor

or-shachar commented Aug 13, 2020

Continuing #11838 and adresses #11838 (comment)

The local_repository rule uses this regex, but says it allows a '.' character, which is currently does not:
local_repository rule //external:shared.name's name field must be a legal workspace name; workspace names may contain only A-Z, a-z, 0-9, '-', '_' and '.'


          Allow dot char in workspace name

4e0d7c5

googlebot added the cla: yes label

gregestren added the team-OSS label

Contributor Author

or-shachar commented Aug 16, 2020

closing due to #11885 (comment)

or-shachar closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes team-OSS