Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DigestUtils.getDigestInExclusiveMode() now that SsdModule has … #14231

Closed
wants to merge 1 commit into from
Closed

Remove DigestUtils.getDigestInExclusiveMode() now that SsdModule has … #14231

wants to merge 1 commit into from

Commits on Nov 5, 2021

  1. Remove DigestUtils.getDigestInExclusiveMode() now that SsdModule has … 

    …been removed

There used to be a cli flag --experimental_multi_threaded_digest which defaulted to true
and therefore would not compute the file digest in exclusive mode unless overridden to false.
When that flag was removed this code was accidentally left behind which instead causes bazel to always
compute file digests in exclusive mode for all files larger than MULTI_THREADED_DIGEST_MAX_FILE_SIZE.

This causes bazel to take 5-6x longer to 'check cached actions' in my org's builds,
specifically increasing the time from 30 secs to 2 mins 30 secs for fully cached no-op builds.

Fixes bazelbuild#14034
    Brandon Jacklyn committed Nov 5, 2021
    Configuration menu
    Copy the full SHA
    88b62f8 View commit details
    Browse the repository at this point in the history