Move LabelConversionContext to a new top-level class. #14815
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add a convenience method to create a label converter for a starlark thread. This makes it more easily available for other uses. Part of Optional Toolchains (bazelbuild#14726).
Wyverald
reviewed
Feb 16, 2022
| this.convertedLabelsInPackage = convertedLabelsInPackage; | ||
| } | ||
|
|
||
| Label getParent() { |
There was a problem hiding this comment.
maybe "Base" (as in base label + relative label, cf. path)? and/or add some light javadoc ("parent" by itself is a bit confusing IMO)
(also fix up argument in constructor)
There was a problem hiding this comment.
Good call, done.
I also cleaned up the other getter methods on LabelConverter, and fixed some logic that uses the converter in BuildType.
Also cleaned up exposed methods on LabelConverter, and fixed some logic in BuildType to be clearer.
Wyverald
approved these changes
Feb 16, 2022
ShreeM01
added
the
team-Configurability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add a convenience method to create a label converter for a starlark
thread.
This makes it more easily available for other uses.
Part of Optional Toolchains (#14726).