Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Optional Toolchains #14726

Closed
katre opened this issue Feb 4, 2022 · 1 comment
Closed

Implement Optional Toolchains #14726

katre opened this issue Feb 4, 2022 · 1 comment
Assignees
@katre
Labels
P1 I'll work on this now. (Assignee required) team-Configurability platforms, toolchains, cquery, select(), config transitions type: feature request

Comments

@katre
Copy link
Member

katre commented Feb 4, 2022

Now that https://github.com/bazelbuild/proposals/blob/main/designs/2022-01-21-optional-toolchains.md is approved, this is the tracking issue for the core implemenation.

Updating rules to use the new feature will be tracked by separate issues.
@katre katre added type: feature request P1 I'll work on this now. (Assignee required) team-Configurability platforms, toolchains, cquery, select(), config transitions labels Feb 4, 2022
@katre katre self-assigned this Feb 4, 2022
@katre katre mentioned this issue Feb 4, 2022
Closed
This was referenced Feb 7, 2022
Open
Merged
katre added a commit to katre/bazel that referenced this issue Feb 8, 2022
@katre
Update ExecGroup to use a Builder interface.
9ad1194 
Also fix tests that access ExecGroup to use the correct Subject.

Part of work on optional toolchains (bazelbuild#14726).
@katre katre mentioned this issue Feb 8, 2022
Closed
bazel-io pushed a commit that referenced this issue Feb 8, 2022
@katre @copybara-github
Update ExecGroup to use a Builder interface.
0d511e8 
Also fix tests that access ExecGroup to use the correct Subject.

Part of work on optional toolchains (#14726).

Closes #14758.

PiperOrigin-RevId: 427265632
katre added a commit to katre/bazel that referenced this issue Feb 9, 2022
@katre
Add new ToolchainTypeRequirement class to track toolchain type status.
86c27ac 
Part of Optional Toolchains (bazelbuild#14726).
@katre katre mentioned this issue Feb 9, 2022
Closed
bazel-io pushed a commit that referenced this issue Feb 9, 2022
@katre @copybara-github
Add non-Starlark optional toolchain API
3333de8 
Part of Optional Toolchains (#14726).

Closes #14770.

PiperOrigin-RevId: 427551659
katre added a commit to katre/bazel that referenced this issue Feb 10, 2022
@katre
Update toolchain resolution to use ToolchainTypeRequirement.
576c3c9 
Actually updating the logic to check mandatory/optional is still TODO.

Part of bazelbuild#14726.
@katre katre mentioned this issue Feb 10, 2022
Closed
bazel-io pushed a commit that referenced this issue Feb 10, 2022
@katre @copybara-github
Update toolchain resolution to use ToolchainTypeRequirement.
cf16e88 
Actually updating the logic to check mandatory/optional is still TODO.

Part of #14726.

Closes #14784.

PiperOrigin-RevId: 427810691
katre added a commit to katre/bazel that referenced this issue Feb 14, 2022
@katre
Update ExecGroup to use ToolchainTypeRequirement
1342d80 
Part of Optional Toolchains (bazelbuild#14726).
@katre katre mentioned this issue Feb 14, 2022
Closed
katre added a commit to katre/bazel that referenced this issue Feb 14, 2022
@katre
Move LabelConversionContext to a new top-level class.
c66b79c 
Also add a convenience method to create a label converter for a starlark
thread.

This makes it more easily available for other uses.

Part of Optional Toolchains (bazelbuild#14726).
@katre katre mentioned this issue Feb 14, 2022
Closed
bazel-io pushed a commit that referenced this issue Feb 14, 2022
@katre @copybara-github
Update ExecGroup to use ToolchainTypeRequirement
3dd3a1b 
Part of Optional Toolchains (#14726).

Closes #14812.

PiperOrigin-RevId: 428601902
katre added a commit to katre/bazel that referenced this issue Feb 15, 2022
@katre
Update AspectDefinition to use ToolchainTypeRequirement.
9c71e03 
Part of Optional Toolchains (bazelbuild#14726).
@katre katre mentioned this issue Feb 15, 2022
Closed
katre added a commit to katre/bazel that referenced this issue Feb 15, 2022
@katre
Add useful factory methods for ToolchainTypeRequirement.
28c92b5 
Part of Optional Toolchains (bazelbuild#14726).
@katre katre mentioned this issue Feb 15, 2022
Closed
bazel-io pushed a commit that referenced this issue Feb 15, 2022
@katre @copybara-github
Add useful factory methods for ToolchainTypeRequirement.
3550a2a 
Part of Optional Toolchains (#14726).

Closes #14825.

PiperOrigin-RevId: 428865799
katre added a commit to katre/bazel that referenced this issue Feb 15, 2022
@katre
Update AspectDefinition to use ToolchainTypeRequirement.
06b3d86 
Part of Optional Toolchains (bazelbuild#14726).
bazel-io pushed a commit that referenced this issue Feb 16, 2022
@katre @copybara-github
Update AspectDefinition to use ToolchainTypeRequirement.
fb16270 
Part of Optional Toolchains (#14726).

Closes #14823.

PiperOrigin-RevId: 429077498
bazel-io pushed a commit that referenced this issue Feb 17, 2022
@katre @copybara-github
Move LabelConversionContext to a new top-level class.
f0cadba 
Also add a convenience method to create a label converter for a starlark
thread.

This makes it more easily available for other uses.

Part of Optional Toolchains (#14726).

Closes #14815.

PiperOrigin-RevId: 429410754
katre added a commit to katre/bazel that referenced this issue Feb 18, 2022
@katre
Update RuleClass to use ToolchainTypeRequirement.
f9f8571 
A future change will update rules.

Part of Optional Toolchains (bazelbuild#14726).
katre added a commit to katre/bazel that referenced this issue Mar 3, 2022
@katre
Update AspectDefinition and StarlarkDefinedAspect to work with
56517e5 
ToolchainTypeRequirement.

Part of Optional Toolchains (bazelbuild#14726).
@katre katre mentioned this issue Mar 3, 2022
Closed
bazel-io pushed a commit that referenced this issue Mar 3, 2022
@katre @copybara-github
Update AspectDefinition and StarlarkDefinedAspect to work with
6f2c3e2 
ToolchainTypeRequirement.

Part of Optional Toolchains (#14726).

Closes #14946.

PiperOrigin-RevId: 432197702
katre added a commit to katre/bazel that referenced this issue Mar 3, 2022
@katre
Update starlark apis that consume toolchain types to use
accd880 
ToolchainTypeRequirement.

Part of Optional Toolchains (bazelbuild#14726).
@katre katre mentioned this issue Mar 3, 2022
Closed
katre added a commit to katre/bazel that referenced this issue Mar 31, 2022
@katre
Update starlark apis that consume toolchain types to use
01c1a8b 
ToolchainTypeRequirement.

Part of Optional Toolchains (bazelbuild#14726).
@gregestren gregestren mentioned this issue Apr 4, 2022
Closed
bazel-io pushed a commit that referenced this issue Apr 5, 2022
@katre @copybara-github
Update starlark apis that consume toolchain types to use
5f6a121 
ToolchainTypeRequirement.

Part of Optional Toolchains (#14726).

Closes #14948.

PiperOrigin-RevId: 439641733
katre added a commit to katre/bazel that referenced this issue Apr 5, 2022
@katre
Add ToolchainTypeRequirement to ToolchainTestCase.
ff0088d 
Part of Optional Toolchains (bazelbuild#14726).
@katre katre mentioned this issue Apr 5, 2022
Closed
bazel-io pushed a commit that referenced this issue Apr 5, 2022
@katre @copybara-github
Add ToolchainTypeRequirement to ToolchainTestCase.
a09d19b 
Part of Optional Toolchains (#14726).

Closes #15186.

PiperOrigin-RevId: 439663330
bazel-io pushed a commit that referenced this issue Apr 13, 2022
@trybka @copybara-github
## Starlark cc_test fixes.
32714ee 
* Restructure `cc_test` to use a toolchain alias. This will allow `cc_test` to work in Bazel (and tests) without a "dummy" toolchain needing to be registered.
This makes `cc_test` use the legacy flow when toolchains are not registered--requiring an additional flag if they are.
This is a temporary measure to permit switching off `native.cc_test` before [Optional Toolchains](#14726) lands.

* Add coverage-related tools (e.g. collect_cc_coverage.sh) necessary for Bazel to collect coverage from cc_test(s)

PiperOrigin-RevId: 441494074
katre added a commit to katre/bazel that referenced this issue Apr 19, 2022
@katre
Use ToolchainTypeRequirement in ToolchainContext and related classes.
e9c1372 
Part of Optional Toolchains (bazelbuild#14726).
@katre katre mentioned this issue Apr 19, 2022
Closed
bazel-io pushed a commit that referenced this issue Apr 19, 2022
@katre @copybara-github
Use ToolchainTypeRequirement in ToolchainContext and related classes.
16c4076 
Part of Optional Toolchains (#14726).

Closes #15293.

PiperOrigin-RevId: 442870291
katre added a commit to katre/bazel that referenced this issue Apr 19, 2022
@katre
Add tests for ResolvedToolchainContext will missing optional toolchains.
2fec3fe 
Part of Optional Toolchains (bazelbuild#14726).
@katre katre mentioned this issue Apr 19, 2022
Closed
bazel-io pushed a commit that referenced this issue Apr 25, 2022
@katre @copybara-github
Add tests for ResolvedToolchainContext with missing optional toolchains.
fafcd5a 
Part of Optional Toolchains (#14726).

Closes #15296.

PiperOrigin-RevId: 444281581
katre added a commit to katre/bazel that referenced this issue Apr 25, 2022
@katre
Update SingleToolchainValue to properly handle missing toolchains.
a2591d9 
This can no longer throw an exception, but needs to signal in the
returned value.

Part of Optional Toolchains (bazelbuild#14726).
@katre katre mentioned this issue Apr 25, 2022
Closed
bazel-io pushed a commit that referenced this issue Apr 25, 2022
@katre @copybara-github
Update SingleToolchainValue to properly handle missing toolchains.
05747cf 
This can no longer throw an exception, but needs to signal in the
returned value.

Part of Optional Toolchains (#14726).

Closes #15338.

PiperOrigin-RevId: 444343903
katre added a commit to katre/bazel that referenced this issue Apr 26, 2022
@katre
Fix StarlarkIndexable.getIndex implementations that return null.
5338455 
They should return Starlark.NONE instead.

Part of Optional Toolchains (bazelbuild#14726).
@katre katre mentioned this issue Apr 26, 2022
Closed
bazel-io pushed a commit that referenced this issue Apr 27, 2022
@katre @copybara-github
Fix StarlarkIndexable.getIndex implementations that return null.
a48e246 
They should return Starlark.NONE instead.

Part of Optional Toolchains (#14726).

Closes #15344.

PiperOrigin-RevId: 444869683
katre added a commit to katre/bazel that referenced this issue Apr 27, 2022
@katre
Update ToolchainResolutionFunction to handle optional toolchain types.
d943a61 
Part of Optional Toolchains (bazelbuild#14726).
@katre katre mentioned this issue Apr 27, 2022
Closed
bazel-io pushed a commit that referenced this issue Apr 29, 2022
@katre @copybara-github
Update ToolchainResolutionFunction to handle optional toolchain types
e6fbe5b 
Part of Optional Toolchains (#14726).

Closes #15357.

PiperOrigin-RevId: 445399501
bazel-io pushed a commit that referenced this issue May 3, 2022
@katre @copybara-github
Update toolchains documentation for new optional toolchains feature.
93db260 
Part of #14726

RELNOTES: Toolchain types may now be optional, in addition to mandatory. See https://bazel.build/docs/toolchains#optional-toolchains for further details.
PiperOrigin-RevId: 446279106
@katre
Copy link
Member Author

katre commented May 4, 2022

This is now complete: followup work for the CC toolchain specifically will be tracked as #14727.

@katre katre closed this as completed May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katre katre

Labels
P1 I'll work on this now. (Assignee required) team-Configurability platforms, toolchains, cquery, select(), config transitions type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@katre