Update AspectDefinition to use ToolchainTypeRequirement. #14823
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katre
commented
Feb 15, 2022
| ToolchainTypeRequirement.builder() | ||
| .toolchainType( | ||
| Label.parseAbsoluteUnchecked(toolsRepository + sdkToolchainLabel)) | ||
| .mandatory(true) |
There was a problem hiding this comment.
I'm a little unhappy with the verbosity here. Should I add a shorter version?
One thought:
.addToolchainType(ToolchainTypeRequirement.builder(typeLabel))
Thoughts?
There was a problem hiding this comment.
Sure. As currently written I had some trouble identifying when the builder resolves and how it generally fits with the pattern.
There was a problem hiding this comment.
Okay, added them as #14825, once that's in I'll rebase this.
Part of Optional Toolchains (bazelbuild#14726).
katre
force-pushed
the
i14726-04-aspect
branch
from
9c71e03 to
06b3d86
Compare
gregestren
approved these changes
Feb 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of Optional Toolchains (#14726).