Fetch android_databinding dependencies with rules_jvm_external #17727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgowroji
added
team-Android
Wyverald
approved these changes
Mar 13, 2023
Wyverald
added
awaiting-PR-merge
|
Non-third_party part merged at 51434e4 |
sgowroji
removed
the
awaiting-PR-merge
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
…hird_party) This PR basically reverts bazelbuild#11629 and fetch android databinding jars and their dependencies with rules_jvm_external instead. We still need to keep `third_party/java/android_databinding/v3_4_0/exec.jar` because it is custom prebuilt tool and there is no corresponding maven coordinate. Working towards: bazelbuild#17036 Closes bazelbuild#17727. PiperOrigin-RevId: 516246992 Change-Id: I122ab5e9037668ac6913ab03df186609bbc0f458
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR basically reverts #11629 and fetch android databinding jars and their dependencies with rules_jvm_external instead.
We still need to keep
third_party/java/android_databinding/v3_4_0/exec.jarbecause it is custom prebuilt tool and there is no corresponding maven coordinate.Working towards: #17036