Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify in tests that coverage supports --nobuild_runfile_links #22676

Closed
wants to merge 1 commit into from
Closed

Verify in tests that coverage supports --nobuild_runfile_links #22676

wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Jun 10, 2024 •
edited
Loading

Fixes #20577

@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Jun 10, 2024
@fmeum fmeum mentioned this pull request Jun 10, 2024
Closed
@fmeum fmeum requested a review from c-mita June 10, 2024 13:33
@fmeum
Copy link
Collaborator Author

fmeum commented Jun 21, 2024

@c-mita Friendly ping

@UebelAndre
Copy link
Contributor

Another ping @c-mita 😄

c-mita
c-mita approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@c-mita c-mita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@c-mita c-mita added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jul 2, 2024
@copybara-service copybara-service bot closed this in c800608 Jul 3, 2024
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jul 3, 2024
fmeum added a commit to fmeum/bazel that referenced this pull request Jul 5, 2024
@fmeum
Verify in tests that coverage supports --nobuild_runfile_links
7be6e90 
Fixes bazelbuild#20577

Closes bazelbuild#22676.

PiperOrigin-RevId: 649065192
Change-Id: I0a57f580c1cb3a03184950e3e5ea24e9ef4962b4
@fmeum fmeum deleted the 20577-add-test branch July 18, 2024 08:33
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Aug 19, 2024
@fmeum @bazel-io
Verify in tests that coverage supports --nobuild_runfile_links
b0a3167 
Fixes bazelbuild#20577

Closes bazelbuild#22676.

PiperOrigin-RevId: 649065192
Change-Id: I0a57f580c1cb3a03184950e3e5ea24e9ef4962b4
@bazel-io bazel-io mentioned this pull request Aug 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-mita c-mita c-mita approved these changes

Assignees

@c-mita c-mita

Labels
team-Core Skyframe, bazel query, BEP, options parsing, bazelrc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remote_coverage_tools/Main cannot locate runfiles directory when building with --nobuild_runfile_links
3 participants
@fmeum @UebelAndre @c-mita