[7.4.0] Verify in tests that coverage supports --nobuild_runfile_links
#23345
+12
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bazelbuild#20577 Closes bazelbuild#22676. PiperOrigin-RevId: 649065192 Change-Id: I0a57f580c1cb3a03184950e3e5ea24e9ef4962b4
bazel-io
added
team-Core
|
@c-mita do you have fix for the presubmit errors? |
|
@iancha1992 @c-mita I don't think this cherry-pick is correct. 404d8d9 is the actual fix whereas the cherry-pick above is only for adding tests |
|
@lberki small ping! would love to get this in 7.4 if possible |
|
@Ryang20718 If a commit causes too much merge conflicts, we may eventually decide not to cherry pick it. But feel free to give it a try if you desperately need it. |
|
We don't have time for this in 7.4.0. If we ever do a 7.5.0, we can revisit. Closing. |
auto-merge was automatically disabled
October 9, 2024 21:07
Pull request was closed
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20577
Closes #22676.
PiperOrigin-RevId: 649065192
Change-Id: I0a57f580c1cb3a03184950e3e5ea24e9ef4962b4
Commit c800608