Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arm cortex-m platform constraints #11

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

nathaniel-brough
Copy link
Contributor

This adds platforms cpu constraints for cortex-m targets;

  • Cortex-M0
  • Cortex-M1
  • Cortex-M4
  • Cortex-M7
  • Cortex-M23
  • Cortex-M33
  • Cortex-M35P

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@nathaniel-brough
Copy link
Contributor Author

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Jan 8, 2021

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: yes and removed cla: no labels Jan 8, 2021
@katre
Copy link
Member

katre commented Jan 8, 2021

What is the intent behind these? What compiler toolchains will need to use this?

@nathaniel-brough
Copy link
Contributor Author

nathaniel-brough commented Jan 9, 2021

The use case is for targeting cortex-m microcontrollers. Example of existing toolchain. This PR covers the majority of all arm cortex microcontroller architectures. The intent is to shift the silvergasp/bazel-embedded repo to depend on the upstream "platforms" repository rather than this fork.

Example use case includes cross compiling google pigweed.

@katre
Copy link
Member

katre commented Jan 12, 2021

Thanks for your patience, I have been doing some research on ARM cpus. I think this PR makes sense, but can you add comments to each constraint stating that it's for Cortex-M0, etc?

@nathaniel-brough
Copy link
Contributor Author

No worries that's an easy change.

@google-cla
Copy link

google-cla bot commented Jan 13, 2021

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

katre
katre previously approved these changes Jan 13, 2021
Copy link
Member

@katre katre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Once #22 is in (it's already started) I'll merge this.

@katre
Copy link
Member

katre commented Jan 13, 2021

Okay, #22 is merged, could you update this to master and then I'll merge it?

@google-cla
Copy link

google-cla bot commented Jan 14, 2021

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@nathaniel-brough
Copy link
Contributor Author

Done!

@katre
Copy link
Member

katre commented Jan 14, 2021

Thanks, starting the merge process now.

@bazel-io bazel-io merged commit 0969b62 into bazelbuild:master Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants