-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add arm cortex-m platform constraints #11
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
a9fb73e
to
cec120c
Compare
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
What is the intent behind these? What compiler toolchains will need to use this? |
The use case is for targeting cortex-m microcontrollers. Example of existing toolchain. This PR covers the majority of all arm cortex microcontroller architectures. The intent is to shift the silvergasp/bazel-embedded repo to depend on the upstream "platforms" repository rather than this fork. Example use case includes cross compiling google pigweed. |
Thanks for your patience, I have been doing some research on ARM cpus. I think this PR makes sense, but can you add comments to each constraint stating that it's for Cortex-M0, etc? |
No worries that's an easy change. |
cec120c
to
89e52d2
Compare
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Once #22 is in (it's already started) I'll merge this.
Okay, #22 is merged, could you update this to master and then I'll merge it? |
89e52d2
to
29bd0fc
Compare
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Done! |
Thanks, starting the merge process now. |
This adds platforms cpu constraints for cortex-m targets;