Make aarch64 an alias of arm64 #22
Conversation
On Apple silicon Macs, auto-detected host platform constraints' cpu is aarch64, but arm64 is used everywhere else. This change ensures that you will get the same cpu when your target depends on an arm64 or an aarch64 cpu contraint.
|
Are these actually the same CPU? I don't know anything about ARM chips. Should we possibly be distinguishing Apple's M1 from other 64-bit ARM chips? |
|
On Apple platforms, I think they refer to the same cpu, not sure about others. Or we can fix the autodetecting toolchain on macOS to use arm64 instead of aarch64. |
|
I'm trying to get some clarification on the details of different ARM cpus from some of my colleagues, and I'll report back once I have something. |
|
Thanks for your patience. I talked to my colleagues, and this PR makes sense. Once this and #11 are in we may need to do another pass to rationalize arm cpus, but this can submit as is. I'll work on merging it today. |
|
Gentle ping @katre |
|
This should be in release https://github.com/bazelbuild/platforms/releases/tag/0.0.4, sorry I didn't comment back here that it was done. |
Running the bazel build on Mac M1 yields the following error: Configurable attribute "actual" doesn't match this configuration: Could not find a JDK for host execution environment, please explicitly provide one using `--host_javabase.` Follow hints in [1] and fix this by loading bazel platforms 0.0.5 which contains a fix [2] making aarch64 an alias of arm64. [1] bazelbuild/bazel#13573 [2] bazelbuild/platforms#22 Release-Notes: Fix bazel build on Mac M1 (aarch64) Change-Id: I5a4ebcd50012a53e5ff92a12e4fa8ba766aed0a7
On Apple silicon Macs, auto-detected host platform constraints' cpu is
aarch64, but arm64 is used everywhere else. This change ensures that you
will get the same cpu when your target depends on an arm64 or an aarch64
cpu contraint.