Skip to content

Commit

Permalink
Document that parent directories of outputs are created implicitly. (#42
Browse files Browse the repository at this point in the history
)

When implementing Buildbarn's worker, I noticed that there exists the
assumption in build rules that directories under bazel-out/ are already
created prior to execution, even if they are not part of the input root.

As I suspect that getting rid of this assumption is both unrealistic and
undesirable, let's document this instead.

Mentioned in: #40
  • Loading branch information
EdSchouten authored and Ola Rozenfeld committed Jan 7, 2019
1 parent 4905c1a commit 78c169a
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions build/bazel/remote/execution/v2/remote_execution.proto
Original file line number Diff line number Diff line change
Expand Up @@ -446,6 +446,9 @@ message Command {
//
// An output file cannot be duplicated, be a parent of another output file, or
// have the same path as any of the listed output directories.
//
// Directories leading up to the output files are created by the worker prior
// to execution, even if they are not explicitly part of the input root.
repeated string output_files = 3;

// A list of the output directories that the client expects to retrieve from
Expand All @@ -470,6 +473,10 @@ message Command {
//
// An output directory cannot be duplicated or have the same path as any of
// the listed output files.
//
// Directories leading up to the output directories (but not the output
// directories themselves) are created by the worker prior to execution, even
// if they are not explicitly part of the input root.
repeated string output_directories = 4;

// The platform requirements for the execution environment. The server MAY
Expand Down

0 comments on commit 78c169a

Please sign in to comment.