Document that parent directories of outputs are created implicitly. #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When implementing Buildbarn's worker, I noticed that there exists the assumption in build rules that directories under bazel-out/ are already created prior to execution, even if they are not part of the input root. As I suspect that getting rid of this assumption is both unrealistic and undesirable, let's document this instead. Mentioned in: bazelbuild#40
googlebot
added
the
cla: yes
ola-rozenfeld
approved these changes
Jan 7, 2019
henryaj
pushed a commit
to henryaj/buildgrid
that referenced
this pull request
Nov 20, 2019
Noteworthy changes include: * From remote_execution.proto: - New message field in ExecuteResponse [1]. - Output file and dir. parent folders clarifications [2]. - Better doc. for do_not_cache/skip_cache_lookup [3]. - Documention updates. * From semver.proto: - Documentation updates. [1] bazelbuild/remote-apis#36 [2] bazelbuild/remote-apis#42 [3] bazelbuild/remote-apis#55
santigl
pushed a commit
to santigl/remote-apis
that referenced
this pull request
Aug 26, 2020
santigl
pushed a commit
to santigl/remote-apis
that referenced
this pull request
Aug 26, 2020
…elbuild#119) * Output directories empty structure support. Fixes bazelbuild#42. * Addressing comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When implementing Buildbarn's worker, I noticed that there exists the
assumption in build rules that directories under bazel-out/ are already
created prior to execution, even if they are not part of the input root.
As I suspect that getting rid of this assumption is both unrealistic and
undesirable, let's document this instead.
Mentioned in: #40