Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only add validation outputs to the _validation output_group #143

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mauriciogg
Copy link
Contributor

Otherwise the --run_validations flag is useless

@mauriciogg
Copy link
Contributor Author

cc @Bencodes

@@ -555,7 +555,6 @@ def finalize(
),
_direct_source_jars = depset([ctx.outputs.lib_src_jar]),
_hidden_top_level_INTERNAL_ = depset(
resources_ctx.validation_results,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these be added to validation_outputs below, or are these already included? I looked through the code and I'm not sure that they're already there, but maybe I missed it

@@ -592,7 +592,6 @@ def impl(ctx):
# Bazel developers so that `bazel build java/com/my_aar_import` will fail if the resource
# processing or JAR merging steps fail.
files_to_build = []
files_to_build.extend(resources_ctx.validation_results) # TODO(djwhang): This should be validation.
Copy link
Collaborator

@ahumesky ahumesky Sep 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these be added to validation_outputs above, or are these already included? I looked through the code and I'm not sure that they're already there, but maybe I missed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants