Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only add validation outputs to the _validation output_group #143

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Only add validation outputs to the _validation output_group #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f088cc
Only add validation outputs to the _validation output_group
mauriciogg Sep 15, 2023
c071b50
Update impl.bzl
mauriciogg Sep 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion rules/aar_import/impl.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,7 +592,6 @@ def impl(ctx):
# Bazel developers so that `bazel build java/com/my_aar_import` will fail if the resource
# processing or JAR merging steps fail.
files_to_build = []
files_to_build.extend(resources_ctx.validation_results) # TODO(djwhang): This should be validation.
Copy link
Collaborator

@ahumesky ahumesky Sep 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these be added to validation_outputs above, or are these already included? I looked through the code and I'm not sure that they're already there, but maybe I missed it

files_to_build.append(merged_jar)

providers.append(
Expand Down
1 change: 0 additions & 1 deletion rules/android_library/impl.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,7 +555,6 @@ def finalize(
),
_direct_source_jars = depset([ctx.outputs.lib_src_jar]),
_hidden_top_level_INTERNAL_ = depset(
resources_ctx.validation_results,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these be added to validation_outputs below, or are these already included? I looked through the code and I'm not sure that they're already there, but maybe I missed it

transitive = [
info._hidden_top_level_INTERNAL_
for info in utils.collect_providers(
Expand Down