-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download the NDK in Bazel #51
base: main
Are you sure you want to change the base?
Conversation
This is ready to review and 🚀 - we're using it as-is in our workspace and everything works nicely. |
Thanks, I'm asking internally whether we can have such a feature in rules_android, since the download pages for the NDK (and SDK fwiw) present Terms and Conditions that you have to accept before downloading. |
Fair point, I guess that could be a problem. However, if this is required, we could maybe think of introducing a feature that users need to toggle once per host or something like that? EDIT: another idea is to add a flag |
One more data point if that helps: I just noticed that the |
Any chance this will land anytime soon? This seem to close #2 too. |
The rule now ignores
ANDROID_NDK_HOME
and defaults to downloading ther25c
NDK for the current platform (failing if the platform is not supported).One can specify three new attributes:
version
to select the NDK to downloadbase_url
if you don't want to usehttps://dl.google.com/android/repository
sha256sums
to add checksums for (yet) unsupported NDK releasesAlso:
repository_ctx
to avoid the rule implementation function from being restarted (this wasn't so visible with the local install)default
in attribute forapi_version
native.register_toolchains()
since this will register the NDK as the default C++ toolchain, which shouldn't be the default assumption.TODO:
ctx
attributes to avoid the rule restarting multiple timesCloses #44