Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Windows host #2

Closed
ahumesky opened this issue Aug 31, 2022 · 7 comments · Fixed by #68
Closed

Add support for Windows host #2

ahumesky opened this issue Aug 31, 2022 · 7 comments · Fixed by #68
Assignees
Labels
enhancement New feature or request P1

Comments

@ahumesky
Copy link
Collaborator

android_ndk_repository in rules.bzl is currently hard-coded for Linux.

@ahumesky ahumesky added the enhancement New feature or request label Aug 31, 2022
@ahumesky ahumesky self-assigned this Aug 31, 2022
@ahumesky ahumesky added the P1 label Sep 1, 2022
@oakad
Copy link

oakad commented Oct 28, 2022

I've got one of my projects compiling fine with rules_android_ndk on Linux and now want to do so on Windows. Alas, as of right now it's still "Unsupported operating system: windows 10".

If something happens in the Windows support direction, I will be happy to test whatever changes are there. :-)

@oakad
Copy link

oakad commented Feb 17, 2023

Windows is still the most used platform by Android devs (AFAIK). By having NDK broken on Bazel/Windows (as people keep upgrading their NDKs), you're essentially telling us to drop Bazel and go look elsewhere.

The ongoing campaign of closing all the old Bazel issues without ever fixing most of them is also not encouraging trust. :-)

@master-hax
Copy link

+1 interested in Windows support

@marcushultman
Copy link

I must be missing something, but it seems like I can't even use this repository_rule since I need to be able to configure my WORKSPACE on multiple platforms (including windows). Even if no target depend on the repository, the whole setup errors out when configuring. How can optionally call android_ndk_repository based on platform from my WORKSPACE?

@ahumesky
Copy link
Collaborator Author

In preparation for this, an updated NDK needs to be added with the Windows BazeCI image: bazelbuild/continuous-integration#1962

@ahumesky
Copy link
Collaborator Author

tomrenn pushed a commit to tomrenn/rules_android_ndk that referenced this issue May 31, 2024
The stdout will contain backslashes, so replace them with forward
slashes.

Working towards bazelbuild#2
tomrenn pushed a commit to tomrenn/rules_android_ndk that referenced this issue May 31, 2024
All tool executables have the filename suffix ".exe".

Fixes bazelbuild#2
tomrenn pushed a commit to tomrenn/rules_android_ndk that referenced this issue May 31, 2024
All tool executables have the filename suffix ".exe".

Fixes bazelbuild#2
tomrenn pushed a commit to tomrenn/rules_android_ndk that referenced this issue Jun 3, 2024
All tool executables have the filename suffix ".exe".

Fixes bazelbuild#2
@oakad
Copy link

oakad commented Jun 23, 2024

These news are most welcome. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants