Windows support for NDK toolchains #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The stdout will contain backslashes, so replace them with forward slashes. Working towards bazelbuild#2
ahumesky
reviewed
Jun 3, 2024
|
with bazelbuild/continuous-integration#1962 (comment) closed, could you add a windows task to https://github.com/bazelbuild/rules_android_ndk/blob/main/.bazelci/presubmit.yml |
tomrenn
force-pushed
the
windows-support
branch
6 times, most recently
from
f7b5ecc
to
9a60498
Compare
All tool executables have the filename suffix ".exe". Fixes bazelbuild#2
tomrenn
force-pushed
the
windows-support
branch
3 times, most recently
from
99baf41
to
6993f85
Compare
ahumesky
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these commits I am able to build native binaries on Windows machines.
Closes #2