Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use constraints from bazel_tools #1953

Closed
limdor opened this issue Nov 8, 2021 · 0 comments · Fixed by #1956
Closed

Do not use constraints from bazel_tools #1953

limdor opened this issue Nov 8, 2021 · 0 comments · Fixed by #1956

Comments

@limdor
Copy link
Contributor

limdor commented Nov 8, 2021

🐞 bug report

Affected Rule

Any that use constraints from bazel_tools

Is this a regression?

No

Description

Constraints from bazel_tools should not be used, instead the ones from https://github.com/bazelbuild/platforms should be used. In Bazel 5.0 this will be flipped and already now to prepare the migration to Bazel 5.0 someone depending on rules_docker cannot flip the flag because rules_docker still uses bazel_tools.
More info in: bazelbuild/bazel#8622

🔬 Minimal Reproduction

Build something with the flag --incompatible_use_platforms_repo_for_constraints

🔥 Exception or Error

invalid registered toolchain '@io_bazel_rules_docker//toolchains/docker:default_linux_toolchain': Analysis of target '@bazel_tools//platforms:linux' failed

🌍 Your Environment

Operating System:

Linux

Output of bazel version:

5.0.0rc1 without he incompatible flag
4.0.0 with incompatible flag

Rules_docker version:

0.19

limdor added a commit to limdor/rules_docker that referenced this issue Nov 8, 2021
gravypod pushed a commit that referenced this issue Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant