Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use constraints from bazel_tools #1956

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

limdor
Copy link
Contributor

@limdor limdor commented Nov 8, 2021

Fixes #1953

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

@gravypod
Copy link
Collaborator

gravypod commented Nov 8, 2021

Hello @limdor. This change looks good but I'd like to know: is there a reason this needs to be done? I'm assuming this blocks some migration or deprecation in bazel_tools or something. I just want to know what to tell future people if they ask about this change.

@gravypod
Copy link
Collaborator

gravypod commented Nov 9, 2021

Ah, I just saw the attached bug! Thanks for putting this together.

@gravypod gravypod merged commit d1327b6 into bazelbuild:master Nov 9, 2021
@limdor
Copy link
Contributor Author

limdor commented Nov 9, 2021

@gravypod it seems that I'm the first one seeing this but this is needed to be able to compile with Bazel 5.0. It would be good if a release could be created soon that contains this changes. Without it rules_docker cannot be used in Bazel 5.0.
The good part is that with this changes works for Bazel 5.0 but it also keeps working for Bazel 4.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not use constraints from bazel_tools
2 participants