Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move usage specific rules into sub repositories. #556

Open
restingbull opened this issue Jul 19, 2021 · 0 comments
Open

Move usage specific rules into sub repositories. #556

restingbull opened this issue Jul 19, 2021 · 0 comments
Labels
component: common P0 status: open - in progress type: cleanup Refactorings, idiomatic transforms, tech debt payoff

Comments

@restingbull
Copy link
Collaborator

This will allow decomposing the current monolithic module into multiple parts and avoid loading unused dependencies such as js when only building jvm, or android when building js.

It also simplifies the recursive downloading step -- when enabled the sub-module can be downloaded with any dependencies.

Steps:

  1. Deprecate access through //kotlin:kotlin.bzl for js, jvm, android, and ktlint rules.
  2. Remove access
  3. Move rule definitions to _ repositories in release archive
  4. Configure repository creating via kt_repositories, which should also add the //kotlin/<type>.bzl file when enabled.
restingbull added a commit that referenced this issue Jul 19, 2021
@restingbull
Add forwarding references for js, jvm, ktlint.
b865a74 
Revert using android rules until they can be loaded via sub repo
Issue: #556

Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>
@restingbull restingbull mentioned this issue Jul 19, 2021
Merged
restingbull added a commit to restingbull/rules_kotlin that referenced this issue Jul 19, 2021
@restingbull
Add forwarding references for js, jvm, ktlint.
74cb1f9 
Revert loading android rules until they can be loaded via sub repo
Issue: bazelbuild#556

Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>
restingbull added a commit to restingbull/rules_kotlin that referenced this issue Jul 21, 2021
@restingbull
Move options to compile.bzl
10aedd8 
Remove references to rules.bzl
Issue: bazelbuild#556

Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>
restingbull added a commit to restingbull/rules_kotlin that referenced this issue Jul 21, 2021
@restingbull
Split up all the functional modules: jvm, js, android, core, reposito…
aa76833 
…ries

Fix the starlark. Stardoc needs the ability to be told that, no, a bzl_library won't exist here. Now, get parsing. Most rules do not expose bzl_libraries making docgen a pain.

Issue: bazelbuild#556
Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>
restingbull added a commit to restingbull/rules_kotlin that referenced this issue Jul 21, 2021
@restingbull
Deprecation announcement is now spammy.
252752a 
Unfortunately, there is no clean builddozer call to split up load statement.
Issue: bazelbuild#556

Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>
restingbull added a commit that referenced this issue Jul 21, 2021
@restingbull
Fix workspace references.
0d98d8a 
Issue: #556
Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>
restingbull added a commit that referenced this issue Jul 21, 2021
@restingbull
Fix workspace references.
0b9c6e6 
Issue: #556
Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>
restingbull added a commit that referenced this issue Jul 23, 2021
@restingbull
Fix more references.
fbe7061 
Centralize the android build tools version.
Issue: #556

Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>
restingbull added a commit that referenced this issue Jul 23, 2021
@restingbull
Lint, lint, lint.
5fbd4a7 
Issue: #556

Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>
restingbull added a commit that referenced this issue Jul 24, 2021
@restingbull
Add forwarding references for js, jvm, ktlint. (#557)
7b7ac2d 
* Add forwarding references for js, jvm, ktlint.

Revert loading android rules until they can be loaded via sub repo
Issue: #556

Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>

* Move options to compile.bzl
Remove references to rules.bzl
Issue: #556

Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>

* Split up all the functional modules: jvm, js, android, core, repositories

Fix the starlark. Stardoc needs the ability to be told that, no, a bzl_library won't exist here. Now, get parsing. Most rules do not expose bzl_libraries making docgen a pain.

Issue: #556
Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>

* Deprecation announcement is now spammy.

Unfortunately, there is no clean builddozer call to split up load statement.
Issue: #556

Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>

* Fix workspace references.

Issue: #556
Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>

* Fix more references.
Centralize the android build tools version.
Issue: #556

Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>

* Lint, lint, lint.
Issue: #556

Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>

* finding the right version...

* finding the right version...

* finding the right version...

* finding the right version...

* matched build tools version

* Use the release reporistories. Whoops.

Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>

* Renamed release.repositories to release.doc reflecting the usage.

Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>
@jongerrish jongerrish mentioned this issue Aug 5, 2021
Merged
@cgruber cgruber added component: common P0 status: open - in progress type: cleanup Refactorings, idiomatic transforms, tech debt payoff labels Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: common P0 status: open - in progress type: cleanup Refactorings, idiomatic transforms, tech debt payoff
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cgruber @restingbull