-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move usage specific rules into sub repositories. #556
Labels
component: common
P0
status: open - in progress
type: cleanup
Refactorings, idiomatic transforms, tech debt payoff
Comments
restingbull
added a commit
that referenced
this issue
Jul 19, 2021
Revert using android rules until they can be loaded via sub repo Issue: #556 Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>
restingbull
added a commit
to restingbull/rules_kotlin
that referenced
this issue
Jul 19, 2021
Revert loading android rules until they can be loaded via sub repo Issue: bazelbuild#556 Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>
restingbull
added a commit
to restingbull/rules_kotlin
that referenced
this issue
Jul 21, 2021
Remove references to rules.bzl Issue: bazelbuild#556 Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>
restingbull
added a commit
to restingbull/rules_kotlin
that referenced
this issue
Jul 21, 2021
…ries Fix the starlark. Stardoc needs the ability to be told that, no, a bzl_library won't exist here. Now, get parsing. Most rules do not expose bzl_libraries making docgen a pain. Issue: bazelbuild#556 Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>
restingbull
added a commit
to restingbull/rules_kotlin
that referenced
this issue
Jul 21, 2021
Unfortunately, there is no clean builddozer call to split up load statement. Issue: bazelbuild#556 Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>
restingbull
added a commit
that referenced
this issue
Jul 21, 2021
Issue: #556 Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>
restingbull
added a commit
that referenced
this issue
Jul 21, 2021
Issue: #556 Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>
restingbull
added a commit
that referenced
this issue
Jul 23, 2021
Centralize the android build tools version. Issue: #556 Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>
restingbull
added a commit
that referenced
this issue
Jul 23, 2021
Issue: #556 Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>
restingbull
added a commit
that referenced
this issue
Jul 24, 2021
* Add forwarding references for js, jvm, ktlint. Revert loading android rules until they can be loaded via sub repo Issue: #556 Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com> * Move options to compile.bzl Remove references to rules.bzl Issue: #556 Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com> * Split up all the functional modules: jvm, js, android, core, repositories Fix the starlark. Stardoc needs the ability to be told that, no, a bzl_library won't exist here. Now, get parsing. Most rules do not expose bzl_libraries making docgen a pain. Issue: #556 Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com> * Deprecation announcement is now spammy. Unfortunately, there is no clean builddozer call to split up load statement. Issue: #556 Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com> * Fix workspace references. Issue: #556 Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com> * Fix more references. Centralize the android build tools version. Issue: #556 Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com> * Lint, lint, lint. Issue: #556 Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com> * finding the right version... * finding the right version... * finding the right version... * finding the right version... * matched build tools version * Use the release reporistories. Whoops. Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com> * Renamed release.repositories to release.doc reflecting the usage. Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>
cgruber
added
component: common
P0
status: open - in progress
type: cleanup
Refactorings, idiomatic transforms, tech debt payoff
labels
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: common
P0
status: open - in progress
type: cleanup
Refactorings, idiomatic transforms, tech debt payoff
This will allow decomposing the current monolithic module into multiple parts and avoid loading unused dependencies such as js when only building jvm, or android when building js.
It also simplifies the recursive downloading step -- when enabled the sub-module can be downloaded with any dependencies.
Steps:
//kotlin:kotlin.bzl
for js, jvm, android, and ktlint rules.kt_repositories
, which should also add the//kotlin/<type>.bzl
file when enabled.The text was updated successfully, but these errors were encountered: