-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add forwarding references for js, jvm, ktlint. #557
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert loading android rules until they can be loaded via sub repo Issue: #556 Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>
restingbull
force-pushed
the
restingbull/fix-android
branch
from
July 19, 2021 18:54
b865a74
to
74cb1f9
Compare
Remove references to rules.bzl Issue: #556 Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>
…ries Fix the starlark. Stardoc needs the ability to be told that, no, a bzl_library won't exist here. Now, get parsing. Most rules do not expose bzl_libraries making docgen a pain. Issue: #556 Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>
Unfortunately, there is no clean builddozer call to split up load statement. Issue: #556 Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>
Issue: #556 Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>
restingbull
force-pushed
the
restingbull/fix-android
branch
from
July 21, 2021 17:56
0d98d8a
to
0b9c6e6
Compare
restingbull
force-pushed
the
restingbull/fix-android
branch
2 times, most recently
from
July 23, 2021 17:09
e4984c0
to
8aae20a
Compare
restingbull
force-pushed
the
restingbull/fix-android
branch
from
July 23, 2021 17:18
8aae20a
to
857458a
Compare
cgruber
requested changes
Jul 23, 2021
kotlin/BUILD
Outdated
), | ||
src_map = { | ||
"dependencies.release.bzl": "dependencies.bzl", | ||
"BUILD.release.bazel": "BUILD.bazel", | ||
"repositories.release.bzl": "repositories.release.bzl", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
repositories.bzl?
Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>
Signed-off-by: restingbull@cabaretmechanique.com <restingbull@cabaretmechanique.com>
cgruber
approved these changes
Jul 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert using android rules until they can be loaded via sub repo
Issue: #556