Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rules_android to 0.5.1 #1205

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Bencodes
Copy link
Collaborator

@Bencodes Bencodes commented Aug 9, 2024

No description provided.

sha256 = versions.ANDROID.SHA,
strip_prefix = "rules_android-%s" % versions.ANDROID.VERSION,
urls = ["https://github.com/bazelbuild/rules_android/archive/v%s.zip" % versions.ANDROID.VERSION],
sha256 = versions.ANDROID.sha256,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use `versions.use_repository(name = "rules_android", rule=http_archive, version =version.ANDROID)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check if this works? It doesn't have the .bazelrc changes the others do.

@Bencodes
Copy link
Collaborator Author

Related bazel-contrib/rules_jvm_external#1215, might be worth while holding off on this PR a bit longer to sort out the --experimental_google_legacy_api situation, otherwise all rules_kotlin users will be forced to enable that flag.

@Bencodes
Copy link
Collaborator Author

Bencodes commented Aug 23, 2024

All of the native providers are being moved into Starlark which will unblock this PR bazelbuild/rules_android@ee0f53d

@ahumesky
Copy link
Collaborator

See bazelbuild/rules_android#256 for updates on the provider Starlark migration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants