-
-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix android_extensions.bzl
with Bazel 8.0.0rc1 and later
#1270
Comments
Presumably the new |
rules_android has only been targeting bazel 7 and 8, we'll have to see what does and doesn't work with bazel 6, and what can be worked around in the rules. I can see when I pick #1215 back up |
Do you actually need to support Bazel 6 with Bzlmod enabled (which is not the default)? |
I was trying to fix this for rules_jvm_external but found out rules_kotlin is also broken
@ahumesky @ted-xie Can we partially revert bazelbuild/bazel@ef1a21f#diff-cefcdd5baa8fc0ebdd3c850a8e698499ecebba0b1072d429743c05b1ef287d2e in Bazel 8.0.0, otherwise, older version of rules_jvm_external and rules_kotlin will just be broken with Bazel 8+ |
We only support |
Yeah, rules_jvm_external@HEAD should probably migrate to use the latest version of rules_android. I sent bazelbuild/bazel#24094 to hopefully make bazel 8 also work with older rules_jvm_external versions. |
That's what my PR that was reverted here is about: #1215 Reapplying / unreverting that is blocked on rules_android 0.6.0, which is blocked on getting it to work with bazel 8.0, which is blocked on protobuf issues (include bazelbuild/bazel#23908 that you reference in bazelbuild/bazel#24094)
rules_kotlin has a pending PR (bazelbuild/rules_kotlin#1205) to update to use rules_android, but they're blocked on rules_jvm_external updating to rules_android (which is blocked as above) rules_kotlin has a similar PR to remove dependending on @bazel_tools (bazelbuild/rules_kotlin#1228) |
How far back do we need to go? Older versions of rules_jvm_external e.g. rely on natively-defined |
Sorry if I've missed a crucial point, but I think it'll help discussions if we can come up with an actual compatibility matrix here. e.g. it would be really good if RJE can retain N-2 LTS versions, but to what degree is this requirement a hard blocker for the other rulesets (android, kotlin, java) to make progress? |
This PR address two problems: - Partially rolledback bazelbuild@ef1a21f to restore android tools extension to avoid breaking older rules_jvm_external and rules_kotlin versions: bazel-contrib/rules_jvm_external#1270 - Add protobuf in MODULE.tools to ensure a Bazel 8 compatible version gets selected. (related bazelbuild#23908) Closes bazelbuild#24094. PiperOrigin-RevId: 690625240 Change-Id: I47e9ab7cab9bbfd09e455fb72d3d99d3e73f1f90
This PR address two problems: - Partially rolledback ef1a21f to restore android tools extension to avoid breaking older rules_jvm_external and rules_kotlin versions: bazel-contrib/rules_jvm_external#1270 - Add protobuf in MODULE.tools to ensure a Bazel 8 compatible version gets selected. (related #23908) Closes #24094. PiperOrigin-RevId: 690651136 Change-Id: I47e9ab7cab9bbfd09e455fb72d3d99d3e73f1f90
Running
bazel mod deps
with Bazel 8.0.0rc1 or later results:This is due to bazelbuild/bazel@ef1a21f and probably should switch to use https://github.com/bazelbuild/rules_android/blob/e7729c61025c394fb77b220b917e15494271d7b8/MODULE.bazel#L140-L141 from rules_android
The text was updated successfully, but these errors were encountered: