Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bazel_tools android usage #1228

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

keith
Copy link
Member

@keith keith commented Oct 17, 2024

This was removed with bazel 8.x and exists in rules_android now

This was removed with bazel 8.x and exists in rules_android now
@mortenmj
Copy link

mortenmj commented Oct 21, 2024

This complicates experimenting with Bazel 8.0rc1, and would presumably complicate migration once Bazel 8.0 is released. Would be great to see it merged some time before that happens (NET 2024-10-28)

@restingbull
Copy link
Collaborator

restingbull commented Oct 21, 2024

This complicates experimenting with Bazel 8.0rc1, and would presumably complicate migration once Bazel 8.0 is released. Would be great to see it merged some time before that happens (NET 2024-10-28)

It's breaking a few integration tests, including bazel 6.4. Will take a a minute to sort that.

ERROR: https://bcr.bazel.build/modules/rules_jvm_external/6.2/MODULE.bazel:93:13: name 'use_repo_rule' is not defined
Loading: 
ERROR: Error computing the main repository mapping: in module dependency chain <root> -> rules_android@0.5.1 -> rules_jvm_external@6.2: error executing MODULE.bazel file for rules_jvm_external@6.2
ERROR: /var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/ec321eb2cc2d0f8f91b676b6d4c66c29/sandbox/linux-sandbox/613/execroot/_main/_tmp/e8ec095c07b8eb8fe6326a99c602b1b8/_bazel_buildkite-agent/9d9df1d6447036986a9e38089c4dc229/external/rules_java~/java/common/proguard_spec_info.bzl:16:20: ProguardSpecProvider is experimental and thus unavailable with the current flags. It may be enabled by setting --experimental_google_legacy_api
WARNING: Target pattern parsing failed.

Which means, by merging, we require all users to --experimental_google_legacy_api at a certain point.

@ahumesky
Copy link
Collaborator

Bazel 7.4.0 (or bazel 8) + the upcoming rules_android 0.6.0 release remove the need for --experimental_google_legacy_api (as discussed on various thread / issues, this is a problem for rules_jvm_external too and why bazel-contrib/rules_jvm_external@ba7310c was reverted in bazel-contrib/rules_jvm_external#1215)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants