Replace java_common.create_provider with JavaInfo and java_common.merge #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jin @git-str @thomaswk Can you please take a look? This is blocking bazelbuild/bazel#5821 |
|
Thank you @jin! \o/ |
cgruber
added a commit
to cgruber/rules_kotlin
that referenced
this pull request
Sep 27, 2019
* master: Add additional CODEOWNERS (bazelbuild#202) update JS example to latest Bazel and rules_nodejs (bazelbuild#201) Update the Java launcher (bazelbuild#199) Replace java_common.create_provider with JavaInfo and java_common.merge (bazelbuild#197) windows building fix (bazelbuild#193)
jongerrish
added a commit
to jongerrish/rules_kotlin
that referenced
this pull request
Apr 16, 2020
…ge (bazelbuild#197) * Replace java_common.create_provider with JavaInfo and java_common.merge * Remove unused java_provider
jongerrish
added a commit
to jongerrish/rules_kotlin
that referenced
this pull request
Apr 16, 2020
* master: Add additional CODEOWNERS (bazelbuild#202) update JS example to latest Bazel and rules_nodejs (bazelbuild#201) Update the Java launcher (bazelbuild#199) Replace java_common.create_provider with JavaInfo and java_common.merge (bazelbuild#197) windows building fix (bazelbuild#193)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The java_common.create_provider() API is going to be deprecated by the bazel team in bazel 1.0 and has to be replaced by JavaInfo() and/or other Java-Starlark exposed APIs.