Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Java launcher #199

Merged
merged 1 commit into from
Aug 30, 2019
Merged

Conversation

puffnfresh
Copy link
Contributor

Includes some fixes like using /usr/bin/env instead of /bin/bash which
makes apps work on weird systems, like mine.

Includes some fixes like using /usr/bin/env instead of /bin/bash which
makes apps work on weird systems, like mine.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@puffnfresh
Copy link
Contributor Author

Tests previously failed with:

rules_kotlin/src/test/kotlin/io/bazel/kotlin/KotlinJvmFriendsVisibilityTest: /bin/bash: bad interpreter: No such file or directory

Now pass with:

//src/test/kotlin/io/bazel/kotlin:KotlinJvmFriendsVisibilityTest         PASSED in 0.5s

@puffnfresh
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@jin
Copy link
Member

jin commented Aug 19, 2019

cc @djwhang

@git-str git-str merged commit 42953f9 into bazelbuild:master Aug 30, 2019
cgruber added a commit to cgruber/rules_kotlin that referenced this pull request Sep 27, 2019
* master:
  Add additional CODEOWNERS (bazelbuild#202)
  update JS example to latest Bazel and rules_nodejs (bazelbuild#201)
  Update the Java launcher (bazelbuild#199)
  Replace java_common.create_provider with JavaInfo and java_common.merge (bazelbuild#197)
  windows building fix (bazelbuild#193)
jongerrish added a commit to jongerrish/rules_kotlin that referenced this pull request Apr 16, 2020
Includes some fixes like using /usr/bin/env instead of /bin/bash which
makes apps work on weird systems, like mine.
jongerrish added a commit to jongerrish/rules_kotlin that referenced this pull request Apr 16, 2020
* master:
  Add additional CODEOWNERS (bazelbuild#202)
  update JS example to latest Bazel and rules_nodejs (bazelbuild#201)
  Update the Java launcher (bazelbuild#199)
  Replace java_common.create_provider with JavaInfo and java_common.merge (bazelbuild#197)
  windows building fix (bazelbuild#193)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants