-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the Java launcher #199
Conversation
Includes some fixes like using /usr/bin/env instead of /bin/bash which makes apps work on weird systems, like mine.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Tests previously failed with:
Now pass with:
|
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
cc @djwhang |
* master: Add additional CODEOWNERS (bazelbuild#202) update JS example to latest Bazel and rules_nodejs (bazelbuild#201) Update the Java launcher (bazelbuild#199) Replace java_common.create_provider with JavaInfo and java_common.merge (bazelbuild#197) windows building fix (bazelbuild#193)
Includes some fixes like using /usr/bin/env instead of /bin/bash which makes apps work on weird systems, like mine.
* master: Add additional CODEOWNERS (bazelbuild#202) update JS example to latest Bazel and rules_nodejs (bazelbuild#201) Update the Java launcher (bazelbuild#199) Replace java_common.create_provider with JavaInfo and java_common.merge (bazelbuild#197) windows building fix (bazelbuild#193)
Includes some fixes like using /usr/bin/env instead of /bin/bash which
makes apps work on weird systems, like mine.