Stop using native java rules as these are now deprecated usages. #258
Conversation
cgruber
added
component: android
component: jvm
P1
type: cleanup
cgruber
requested review from
djwhang,
git-str,
jin,
thomaswk and
timpeut
as code owners
WORKSPACE
Outdated
| kt_register_toolchains() | ||
|
|
||
| http_archive( |
There was a problem hiding this comment.
There's a vendored @rules_java in every Bazel installation. Do we need this here?
There was a problem hiding this comment.
Oh? Nice! I guess we do not. Though it semi-forces the kotlin rules to use whatever is in the current bazel... that definitely ties the lifecycles, but in practice, they're already tied, so it's no worse, and there's less hassle. I'll remove. Do I need to declare it or is it just available as @rules_java?
There was a problem hiding this comment.
It's available as @rules_java, no need to declare. Bazel prefixes and suffixes every WORKSPACE with some implicit repositories, and @rules_java is one of them.
There was a problem hiding this comment.
Nice - is there a list? (Also... done)
There was a problem hiding this comment.
here, https://source.bazel.build/bazel/+/master:src/main/java/com/google/devtools/build/lib/bazel/rules/java/jdk.WORKSPACE;l=3;drc=a6cd408876dd55c988a123af8237807bee549a5b has some but not all.
There's no canonical list AFAIK. you can also get a hint by looking at Bazel's own WORKSPACE file here:
cgruber
force-pushed
the
fix/incompatible_native_java_rules
branch
from
f461be6 to
477a1f1
Compare
cgruber
force-pushed
the
fix/incompatible_native_java_rules
branch
from
477a1f1 to
1109277
Compare
cgruber
added
status: closed - fixed
and removed
status: in review
* upstream/master: typo and add missing paren. Add release legacy-1.3.0 Reference proper "current release" as legacy 1.3.0 Update README to account for legacy-1.3.0 release. Fix bad date in changelog Release the Kotlin rules in a simplified workspace relying on precompiled jars. (bazelbuild#271) Update CODEOWNERS (remove str, thomaswk) (bazelbuild#272) Factor out external workspace versions and SHA256s into variables conveniently placed at the top. (bazelbuild#259) Add a link to the generated documentation (bazelbuild#237) Stop using native java rules (bazelbuild#258) Add InteliiJ aspect info (bazelbuild#242) Change readme file formatting (bazelbuild#243) Update CHANGELOG.md Update readme to release candidate 4 Tweak the inference of the test class's package a bit, to support src/test/kotlin/ and kotlin/, since while it's common for kotlin files to live in a /java/ root, it's not UNcommon for them to live in a *kotlin/ root. (bazelbuild#257) Passthrough tags to the container android_library (bazelbuild#255) Fix current "latest" to actually be the latest. Update CHANGELOG.md Update to release legacy-1.3.0-rc3 Support more recent java versions in the kotlin toolchain. (bazelbuild#236)
* origin/master: Stop using native java rules (bazelbuild#258) Add InteliiJ aspect info (bazelbuild#242) Change readme file formatting (bazelbuild#243) Update CHANGELOG.md Update readme to release candidate 4 Tweak the inference of the test class's package a bit, to support src/test/kotlin/ and kotlin/, since while it's common for kotlin files to live in a /java/ root, it's not UNcommon for them to live in a *kotlin/ root. (bazelbuild#257) Passthrough tags to the container android_library (bazelbuild#255) Fix current "latest" to actually be the latest.
Fixes #247