Release the Kotlin rules in a simplified workspace relying on precompiled jars. #271

restingbull · 2020-02-05T20:59:16Z

Minor fix for the kt_jvm_import to work with the IntelliJ Bazel Plugin (Issue: bazelbuild/intellij#1616)
Move android_sdk import to third_party
Introduce release_archive macro to package the repository
Add //:rules_kotlin_release to generate a .tgz suitable for release

TESTED: All kotlin examples.

…ij/issues/1616

Move toolchain configuration to the toolchains.bzl Issue: bazelbuild#269 (comment)

googlebot · 2020-02-05T20:59:22Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

restingbull · 2020-02-05T21:00:54Z

@googlebot I signed it!

Covered under the Square CLA

googlebot · 2020-02-05T21:18:44Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

WORKSPACE

examples/node/WORKSPACE

kotlin/internal/jvm/jvm.bzl

kotlin/internal/repositories/BUILD

kotlin/internal/toolchains.bzl

kotlin/internal/utils/packager.bzl

src/main/kotlin/BUILD

third_party/BUILD

Added //:rules_kotlin_release to build a release. Issue: bazelbuild#269 (comment)

Make examples use the release repository Issue: bazelbuild#269 (comment)

Make examples use the release repository Make git ignore profiling artifacts Issue: bazelbuild#269 (comment)

googlebot · 2020-02-08T02:54:03Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot · 2020-02-08T21:20:07Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

googlebot · 2020-02-08T21:21:51Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

googlebot · 2020-02-08T21:25:08Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

cgruber · 2020-02-10T18:08:46Z

Note, this PR sets the stage for what will become a new way of building from head - but at this point, this PR does not require such changes.

* upstream/master: typo and add missing paren. Add release legacy-1.3.0 Reference proper "current release" as legacy 1.3.0 Update README to account for legacy-1.3.0 release. Fix bad date in changelog Release the Kotlin rules in a simplified workspace relying on precompiled jars. (bazelbuild#271) Update CODEOWNERS (remove str, thomaswk) (bazelbuild#272) Factor out external workspace versions and SHA256s into variables conveniently placed at the top. (bazelbuild#259) Add a link to the generated documentation (bazelbuild#237) Stop using native java rules (bazelbuild#258) Add InteliiJ aspect info (bazelbuild#242) Change readme file formatting (bazelbuild#243) Update CHANGELOG.md Update readme to release candidate 4 Tweak the inference of the test class's package a bit, to support src/test/kotlin/ and kotlin/, since while it's common for kotlin files to live in a /java/ root, it's not UNcommon for them to live in a *kotlin/ root. (bazelbuild#257) Passthrough tags to the container android_library (bazelbuild#255) Fix current "latest" to actually be the latest. Update CHANGELOG.md Update to release legacy-1.3.0-rc3 Support more recent java versions in the kotlin toolchain. (bazelbuild#236)

…m_upstream * upstream/master: typo and add missing paren. Add release legacy-1.3.0 Reference proper "current release" as legacy 1.3.0 Update README to account for legacy-1.3.0 release. Fix bad date in changelog Release the Kotlin rules in a simplified workspace relying on precompiled jars. (bazelbuild#271) Update CODEOWNERS (remove str, thomaswk) (bazelbuild#272) Factor out external workspace versions and SHA256s into variables conveniently placed at the top. (bazelbuild#259) Add a link to the generated documentation (bazelbuild#237)

…iled jars. (bazelbuild#271) * Add work around for Intellij SrcJar bug: github.com/bazelbuild/intellij/issues/1616 * Move android_sdk to 3rd_party Move toolchain configuration to the toolchains.bzl Issue: bazelbuild#269 (comment) * Introduce release_archive for packaging the Kotlin rules. Added //:rules_kotlin_release to build a release. Issue: bazelbuild#269 (comment) * Move maven repo back to kotlin_repos Make examples use the release repository Issue: bazelbuild#269 (comment) * Move maven repo back to kotlin_repos Make examples use the release repository Issue: bazelbuild#269 (comment) * Move maven repo back to kotlin_repos Make examples use the release repository Make git ignore profiling artifacts Issue: bazelbuild#269 (comment) * Apply buildifier and update reflow_skylark script to run. * Removed extranous visibility. * Fixing merge errors in packager.bzl * build the release in the parent directory. * rename to retry presubmit * fix accidental target rename.

Corbin Smith added 2 commits February 4, 2020 12:34

Add work around for Intellij SrcJar bug: github.com/bazelbuild/intell…

4eb5d2c

…ij/issues/1616

Move android_sdk to 3rd_party

7d99a44

Move toolchain configuration to the toolchains.bzl Issue: bazelbuild#269 (comment)

restingbull requested review from cgruber, djwhang, git-str, jin, thomaswk and timpeut as code owners February 5, 2020 20:59

restingbull force-pushed the release-binary-pkg branch from 710ba18 to ab23b13 Compare February 5, 2020 21:18

cgruber reviewed Feb 6, 2020

View reviewed changes

Introduce release_archive for packaging the Kotlin rules.

765c21a

Added //:rules_kotlin_release to build a release. Issue: bazelbuild#269 (comment)

restingbull force-pushed the release-binary-pkg branch from ab23b13 to 765c21a Compare February 6, 2020 18:53

Corbin Smith added 3 commits February 6, 2020 11:48

Move maven repo back to kotlin_repos

0c6e6ea

Make examples use the release repository Issue: bazelbuild#269 (comment)

Move maven repo back to kotlin_repos

7103070

Make examples use the release repository Issue: bazelbuild#269 (comment)

Move maven repo back to kotlin_repos

4428b16

Make examples use the release repository Make git ignore profiling artifacts Issue: bazelbuild#269 (comment)

restingbull force-pushed the release-binary-pkg branch from abb9183 to 4428b16 Compare February 6, 2020 21:08

Corbin Smith added 3 commits February 6, 2020 13:33

Apply buildifier and update reflow_skylark script to run.

8e0f006

Removed extranous visibility.

6e1457c

Fixing merge errors in packager.bzl

9bc3acd

restingbull force-pushed the release-binary-pkg branch from 6b27f8d to 9bc3acd Compare February 8, 2020 21:19

build the release in the parent directory.

5f43f5e

restingbull force-pushed the release-binary-pkg branch from efebd69 to 5f43f5e Compare February 8, 2020 21:24

rename to retry presubmit

2e31778

fix accidental target rename.

3a8e90a

cgruber approved these changes Feb 10, 2020

View reviewed changes

cgruber merged commit ae70089 into bazelbuild:master Feb 10, 2020

cgruber mentioned this pull request Feb 10, 2020

Fix regression introduced in #271 for legacy use of "jars" in kt_jvm_import #276

Merged

restingbull deleted the release-binary-pkg branch February 18, 2020 22:50

Kernald mentioned this pull request Mar 23, 2020

Move public Starlark API to defs.bzl buildfoundation/bazel_rules_detekt#53

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release the Kotlin rules in a simplified workspace relying on precompiled jars. #271

Release the Kotlin rules in a simplified workspace relying on precompiled jars. #271

restingbull commented Feb 5, 2020

googlebot commented Feb 5, 2020

restingbull commented Feb 5, 2020

googlebot commented Feb 5, 2020

googlebot commented Feb 8, 2020

googlebot commented Feb 8, 2020

googlebot commented Feb 8, 2020

googlebot commented Feb 8, 2020

cgruber commented Feb 10, 2020

Release the Kotlin rules in a simplified workspace relying on precompiled jars. #271

Release the Kotlin rules in a simplified workspace relying on precompiled jars. #271

Conversation

restingbull commented Feb 5, 2020

googlebot commented Feb 5, 2020

What to do if you already signed the CLA

Individual signers

Corporate signers

restingbull commented Feb 5, 2020

googlebot commented Feb 5, 2020

googlebot commented Feb 8, 2020

googlebot commented Feb 8, 2020

googlebot commented Feb 8, 2020

googlebot commented Feb 8, 2020

cgruber commented Feb 10, 2020