Reorganize the source tree

[aiuto]

• WORKSPACE moves up one level
  • this makes //:pkg.bzl effectively //pkg:pkg.bzl
  • put forwarders in place at top level to not break anyone
• tests moves up one level
• toolchains moves up one level
• examples/**/BUILD do not change to the new rule locations
  • this is explicitly to provide some proof that the forwarders work
  • new examples should use the proper paths to .bzl files
  • near the 1.x release we can clean the current ones up

Updates the version to 0.6.0. It is mostly an invisible change, but some usage around cloning/vendoring might slightly break.

Fixes: #104

[nacl]

I'll take a deeper look shortly, but one quick thing that comes to mind is that while this won't break anyone using the release archive, it will break people directly cloning the git repo. Is this intentional? Seems fine to me.

[aiuto]

I am fine with that. I don't think it will break that many people, because they old workspace is still around,

…

On Wed, Nov 3, 2021 at 11:37 AM Andrew Psaltis ***@***.***> wrote: I'll take a deeper look shortly, but one quick thing that comes to mind is that while this won't break anyone using the release archive, it will break people directly cloning the git repo. Is this intentional? Seems fine to me. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#443 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAXHHHFRFIW35DTLP4CGV4DUKFQNPANCNFSM5GOZZNQQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[nacl]

I am fine with that. I don't think it will break that many people, because
they old workspace is still around,

That's fine, but looking at https://github.com/aiuto/rules_pkg/tree/reroot/pkg, the old WORKSPACE seems to be missing.

[nacl]

Cool. Most of the stuff I saw here was nits that buildifier might see later. Nothing critical.

[aiuto]

I am at $ rpmbuild --version RPM version 4.16.1.2 I fail with File "/usr/local/google/home/aiuto/.cache/bazel/_bazel_aiuto/307c3de820d1750f8c959c1b06ff6c18/sandbox/linux-sandbox/251/execroot/rules_pkg/bazel-out/k8-fastbuild/bin/tests/rpm/source_date_epoch/source_date_epoch_from_file.runfiles/rules_pkg/tests/rpm/source_date_epoch/rpm_contents_vs_manifest_test.py", line 100, in test_buildtime_set self.assertEqual(actual_epoch, EXPECTED_EPOCH) AssertionError: '1635968773' != '1616472000' - 1635968773 + 1616472000

…

On Wed, Nov 3, 2021 at 3:41 PM Andrew Psaltis ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In tests/rpm/source_date_epoch/BUILD <#443 (comment)>: > ***@***.***_pkg//pkg:mappings.bzl", "pkg_filegroup", "pkg_files") ***@***.***_pkg//pkg:rpm.bzl", "pkg_rpm") Huh. I thought that they would be skipped, given what I have here: https://github.com/bazelbuild/rules_pkg/blob/main/pkg/tests/rpm/source_date_epoch/rpm_contents_vs_manifest_test.py#L57-L64 That change may simply not be working, though. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#443 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAXHHHHHB24OXPYAAXHB4JTUKGNADANCNFSM5GOZZNQQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.