Add .bazelignore to skip deb_packages, examples subdirectories #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of bazelbuild#443, all of the rules_pkg files are now in a WORKSPACE relative to the root of the repository. These are now shared with the `deb_packages/` and `examples/` subdirectories, which contain their own WORKSPACE files. This confuses Bazel and prevents us from testing `//...`. This changes allows us to build/test `//...` by adding those directories to a .bazelignore file at the root of the repository. Most people working on rules_pkg aren't going to be touching these, and if they are, they need to be in those WORKSPACEs anyway, so there should be no harm in this.
aiuto
approved these changes
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of #443, all of the rules_pkg files are now in a WORKSPACE relative to the
root of the repository. These are now shared with the
deb_packages/andexamples/subdirectories, which contain their own WORKSPACE files. Thisconfuses Bazel and prevents us from testing
//....This changes allows us to build/test
//...by adding those directories to a.bazelignore file at the root of the repository.
Most people working on rules_pkg aren't going to be touching these, and if they
are, they need to be in those WORKSPACEs anyway, so there should be no harm in
this.