Skip to content

Commit

Permalink
chore: fix sphinx requirements (#1648)
Browse files Browse the repository at this point in the history
Before this PR the requirements files for `osx` and `linux` would be
split, but in practise they would be always the same. This means that
`linux` users would have to ask an `osx` user to run a command where
we could actually just reuse the same files.

Summary:
- chore: add absl-py to `osx` requirements
- chore: remove the `osx` requirements and rename
`requirements_linux.txt`
  to just be `requirements.txt` as both of the files are the same.
  • Loading branch information
aignas authored Dec 21, 2023
1 parent 5ba63a8 commit 8f1ac0a
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 343 deletions.
3 changes: 1 addition & 2 deletions MODULE.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,5 @@ dev_pip.parse(
},
hub_name = "dev_pip",
python_version = "3.11",
requirements_darwin = "//docs/sphinx:requirements_darwin.txt",
requirements_lock = "//docs/sphinx:requirements_linux.txt",
requirements_lock = "//docs/sphinx:requirements.txt",
)
3 changes: 1 addition & 2 deletions WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,7 @@ pip_parse(
},
incompatible_generate_aliases = True,
python_interpreter_target = interpreter,
requirements_darwin = "//docs/sphinx:requirements_darwin.txt",
requirements_lock = "//docs/sphinx:requirements_linux.txt",
requirements_lock = "//docs/sphinx:requirements.txt",
)

load("@dev_pip//:requirements.bzl", docs_install_deps = "install_deps")
Expand Down
3 changes: 1 addition & 2 deletions docs/sphinx/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,6 @@ sphinx_build_binary(
compile_pip_requirements(
name = "requirements",
src = "pyproject.toml",
requirements_darwin = "requirements_darwin.txt",
requirements_txt = "requirements_linux.txt",
requirements_txt = "requirements.txt",
target_compatible_with = _TARGET_COMPATIBLE_WITH,
)
File renamed without changes.
Loading

0 comments on commit 8f1ac0a

Please sign in to comment.