Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix sphinx requirements #1648

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

aignas
Copy link
Collaborator

@aignas aignas commented Dec 21, 2023

Before this PR the requirements files for osx and linux would be
split, but in practise they would be always the same. This means that
linux users would have to ask an osx user to run a command where
we could actually just reuse the same files.

Summary:

  • chore: add absl-py to osx requirements
  • chore: remove the osx requirements and rename requirements_linux.txt
    to just be requirements.txt as both of the files are the same.

Them getting out of sync was a problem in a few other PRs
and at the moment they are identical, so maybe we can remove
one and assume that they are the same on all platforms?
@aignas aignas requested a review from rickeylev as a code owner December 21, 2023 04:52
@aignas aignas enabled auto-merge December 21, 2023 05:33
Copy link
Collaborator

@groodt groodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aignas aignas added this pull request to the merge queue Dec 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 21, 2023
@rickeylev rickeylev added this pull request to the merge queue Dec 21, 2023
Merged via the queue into bazelbuild:main with commit 8f1ac0a Dec 21, 2023
3 checks passed
@aignas aignas deleted the fix/update-sphinx-requirements branch May 13, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants