fix: always ignore .pyc.NNNN
files from the hermetic runtime tree
#1541
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the pyc compilation process is to create a temporary file named
<name>.pyc.NNNN
, whereNNNN
is a timestamp. Once the pyc is entirely written, this file is renamed to the regular pyc file name. These files only exist for brief periods of time, but its possible for different threads/processes to see the temporary files when computing the glob() values. Later, since the file is gone, an error is raised about the file missing.PR #1266 mostly fixed this issue, except that the exclude for the
.pyc.NNNN
files for aninterpreter runtime's files was behind the
ignore_root_user_error
flag, which meant itwasn't always applied. This changes it to always be applied, which should eliminate the
failures due to the missing NNNN files.
Fixes #1261
Work towards #1520