Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always ignore .pyc.NNNN files from the hermetic runtime tree #1541

Merged
merged 1 commit into from
Nov 7, 2023

Commits on Nov 6, 2023

  1. fix: always ignore .pyc.NNNN files from the hermetic runtime tree

    Part of the pyc compilation process is to create a temporary file named
    `<name>.pyc.NNNN`, where `NNNN` is a timestamp. Once the pyc is entirely
    written, this file is renamed to the regular pyc file name. These files
    only exist for brief periods of time, but its possible for different
    threads/processes to see the temporary files when computing the glob()
    values. Later, since the file is gone, an error is raised about the file
    missing.
    
    PR bazelbuild#1266 mostly fixed this issue, except that the glob exclude for an
    interpreter runtime's files was behind the `ignore_root_user_error`
    flag, which meant it wasn't always applied. This changes it to always be
    applied, which should eliminate the failures.
    
    Fixes bazelbuild#1261
    
    Work towards bazelbuild#1520
    rickeylev committed Nov 6, 2023
    Configuration menu
    Copy the full SHA
    958ad68 View commit details
    Browse the repository at this point in the history