Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing windows CI #344

Closed
wants to merge 2 commits into from
Closed

Conversation

alexeagle
Copy link
Contributor

@alexeagle alexeagle commented Jul 19, 2020

Fixes #2 (if we can get it green)

@thundergolfer
Copy link

Failing due to google/subpar#39 (comment)

@thundergolfer
Copy link

There's a whole lot of Windows specific logic in https://github.com/bazelbuild/bazel/blob/1a0852199d05bef95fcceaa1ef244c36d393bfb0/src/main/java/com/google/devtools/build/lib/bazel/rules/python/BazelPythonSemantics.java that ends up creating the <target_name>.exe that is in this case compiler.exe.

Somewhere in there a non-UTF-8 char is being introduced, or the whole file is actually just binary and not a text-based bash file like in Unix.

I'd say I'd be better to address this issue be replacing the .par files, like we did in rules_python_external.

@alexeagle
Copy link
Contributor Author

Agreed that the best path forward here is to upstream rules_python_external approach.

@github-actions
Copy link

This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days.
Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_python!

@github-actions github-actions bot added the Can Close? Will close in 30 days if there is no new activity label Apr 14, 2021
@thundergolfer thundergolfer self-assigned this Apr 19, 2021
@thundergolfer thundergolfer removed the Can Close? Will close in 30 days if there is no new activity label Apr 19, 2021
@UebelAndre
Copy link
Contributor

@alexeagle this could probably be closed now that #585 has been merged

@alexeagle alexeagle closed this Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows support
4 participants