Enabled CI for Windows #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UebelAndre
force-pushed
the
windows
branch
9 times, most recently
from
fafcedb to
fb92f00
Compare
UebelAndre
requested review from
andyscott,
brandjon,
lberki and
thundergolfer
as code owners
|
@alexeagle you may want to take a look at the changes to the integration test runner. I could be mistaken but I think you have the most context on that bit of code 😅 |
alexeagle
reviewed
Dec 29, 2021
|
@alexeagle all comments addressed and ready for another review 😄 |
|
Does this fix #2 ? if not, do you know what's left? |
alexeagle
reviewed
Dec 29, 2021
I'm not entirely sure. I just recalled seeing a "Add windows support" style issue and thought it'd be relevant to this. |
|
This PR would also close out #344 |
UebelAndre
force-pushed
the
windows
branch
2 times, most recently
from
8d331ea to
84204c3
Compare
12 tasks
12 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
This change includes all the necessary fixes and updates to support enabling CI for windows platforms.
What is the current behavior?
Issue Number: #2
I don't know if this closes #2 but seems related
What is the new behavior?
Updated rules and tests to support windows platforms.
Does this PR introduce a breaking change?
Other information
closes #572