Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positive tests in CI for Windows #597

Closed
wants to merge 2 commits into from

Conversation

jheaff1
Copy link
Contributor

@jheaff1 jheaff1 commented Jan 6, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

The error code of the invocation of "bazel shutdown" was queried to
ascertain the result of "bazel test".

Issue Number: #585

What is the new behavior?

Now, if the invocation of any
bazel command fails, the test_runner.py script will return code 3.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

The error code of the invocation of "bazel shutdown" was queried to
ascertain the result of "bazel test". Now, if the invocation of any
bazel command fails, the test_runner.py script will return code 3.
@jheaff1
Copy link
Contributor Author

jheaff1 commented Jan 6, 2022

It seems that colorama is required in a requirements.lock file on Windows but must be absent on Linux or MacOS. :(

@UebelAndre
Copy link
Contributor

I think the solution here is to find a replacement for sphinx. The dependencies used should use all the same requirements on all platforms or we'd need to implement #260

@UebelAndre
Copy link
Contributor

@jheaff1 I picked up these changes in #598 in case you wanted to collaborate there.

@f0rmiga
Copy link
Collaborator

f0rmiga commented Feb 11, 2022

Addressed in #598 and #595.

@f0rmiga f0rmiga closed this Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants