-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Add option to use "pip download" instead of "pip wheel" to do… #808
Conversation
@UebelAndre I prefer to revert, review the fix, merge the fix if good and then revert the revert. |
…l" to do… (bazelbuild#808)" This reverts commit 4999f63.
@UebelAndre I did similar in #811 Can you close #810 so all the context is self-contained? |
Sorry, figured it'd be more convenient for me to open it so you could be the reviewer (not needing another |
No worries. Thanks! I should have been more clear that I intended to do it. I was just unwinding the PRs. The PR should merge shortly and I'll tag a new release in the next few days as well. |
bazelbuild#808) Revert "Add option to use "pip download" instead of "pip wheel" to download wheels for other platforms (bazelbuild#773)" This reverts commit 6a43ebd.
…wnload wheels for other platforms (#773)"
This reverts commit 6a43ebd.
Exploring if this PR is causing main to fail. See: https://buildkite.com/bazel/rules-python-python/builds/3242#0182dec5-050b-4fa3-9506-5e606ad0c4e1
Update: Reverting this PR will fix main. I think I should have updated the PR branch before merging because it was a bit old (25 days).